Re: [Mesa-dev] [PATCH] mesa: Define helper function to get the number of texture layers.

2013-12-11 Thread Daniel Vetter
On Tue, Dec 10, 2013 at 06:31:55PM -0800, Matt Turner wrote: On Tue, Dec 10, 2013 at 5:55 PM, Francisco Jerez curroje...@riseup.net wrote: It just seems annoying and unnecessary to me to have to repeat the same pattern before each use of unreachable(). If by definition the unreachable

Re: [Mesa-dev] [PATCH] mesa: Define helper function to get the number of texture layers.

2013-12-11 Thread Brian Paul
On 12/10/2013 03:27 PM, Francisco Jerez wrote: Brian Paul bri...@vmware.com writes: On 12/10/2013 11:06 AM, Francisco Jerez wrote: Paul Berry stereotype...@gmail.com writes: On 10 December 2013 08:42, Francisco Jerez curroje...@riseup.net wrote: Brian Paul bri...@vmware.com writes: On

Re: [Mesa-dev] [PATCH] mesa: Define helper function to get the number of texture layers.

2013-12-11 Thread Francisco Jerez
Brian Paul bri...@vmware.com writes: On 12/10/2013 03:27 PM, Francisco Jerez wrote: Brian Paul bri...@vmware.com writes: [...] I'm more convinced now that we should simply have an assert there rather than unreachable(). Finally, in release builds we generally don't want to crash in these

Re: [Mesa-dev] [PATCH] mesa: Define helper function to get the number of texture layers.

2013-12-11 Thread Paul Berry
On 11 December 2013 08:56, Brian Paul bri...@vmware.com wrote: On 12/10/2013 03:27 PM, Francisco Jerez wrote: Brian Paul bri...@vmware.com writes: On 12/10/2013 11:06 AM, Francisco Jerez wrote: Paul Berry stereotype...@gmail.com writes: On 10 December 2013 08:42, Francisco Jerez

Re: [Mesa-dev] [PATCH] mesa: Define helper function to get the number of texture layers.

2013-12-11 Thread Francisco Jerez
Paul Berry stereotype...@gmail.com writes: [...] I'm glad you're dragging this out, Brian. IMHO we have to think carefully about these sorts of issues to keep the quality of Mesa high. Now that I've spent a day ruminating about this, I've changed my mind somewhat. The question at hand is

Re: [Mesa-dev] [PATCH] mesa: Define helper function to get the number of texture layers.

2013-12-11 Thread Paul Berry
On 11 December 2013 12:37, Francisco Jerez curroje...@riseup.net wrote: Paul Berry stereotype...@gmail.com writes: [...] I'm glad you're dragging this out, Brian. IMHO we have to think carefully about these sorts of issues to keep the quality of Mesa high. Now that I've spent a day

Re: [Mesa-dev] [PATCH] mesa: Define helper function to get the number of texture layers.

2013-12-10 Thread Francisco Jerez
Brian Paul bri...@vmware.com writes: On 12/07/2013 06:17 PM, Francisco Jerez wrote: [...] + default: + unreachable(); I think I'd like to see an assertion or _mesa_problem() call to catch unhandled cases if new texture targets are added in the future. How about having the

Re: [Mesa-dev] [PATCH] mesa: Define helper function to get the number of texture layers.

2013-12-10 Thread Brian Paul
On 12/10/2013 09:42 AM, Francisco Jerez wrote: Brian Paul bri...@vmware.com writes: On 12/07/2013 06:17 PM, Francisco Jerez wrote: [...] + default: + unreachable(); I think I'd like to see an assertion or _mesa_problem() call to catch unhandled cases if new texture targets are added

Re: [Mesa-dev] [PATCH] mesa: Define helper function to get the number of texture layers.

2013-12-10 Thread Paul Berry
On 10 December 2013 08:42, Francisco Jerez curroje...@riseup.net wrote: Brian Paul bri...@vmware.com writes: On 12/07/2013 06:17 PM, Francisco Jerez wrote: [...] + default: + unreachable(); I think I'd like to see an assertion or _mesa_problem() call to catch unhandled cases

Re: [Mesa-dev] [PATCH] mesa: Define helper function to get the number of texture layers.

2013-12-10 Thread Brian Paul
On 12/10/2013 11:06 AM, Francisco Jerez wrote: Paul Berry stereotype...@gmail.com writes: On 10 December 2013 08:42, Francisco Jerez curroje...@riseup.net wrote: Brian Paul bri...@vmware.com writes: On 12/07/2013 06:17 PM, Francisco Jerez wrote: [...] + default: + unreachable();

Re: [Mesa-dev] [PATCH] mesa: Define helper function to get the number of texture layers.

2013-12-10 Thread Matt Turner
On Tue, Dec 10, 2013 at 1:31 PM, Brian Paul bri...@vmware.com wrote: On 12/10/2013 11:06 AM, Francisco Jerez wrote: Paul Berry stereotype...@gmail.com writes: On 10 December 2013 08:42, Francisco Jerez curroje...@riseup.net wrote: Brian Paul bri...@vmware.com writes: On 12/07/2013 06:17

Re: [Mesa-dev] [PATCH] mesa: Define helper function to get the number of texture layers.

2013-12-10 Thread Francisco Jerez
Brian Paul bri...@vmware.com writes: On 12/10/2013 11:06 AM, Francisco Jerez wrote: Paul Berry stereotype...@gmail.com writes: On 10 December 2013 08:42, Francisco Jerez curroje...@riseup.net wrote: Brian Paul bri...@vmware.com writes: On 12/07/2013 06:17 PM, Francisco Jerez wrote: [...]

Re: [Mesa-dev] [PATCH] mesa: Define helper function to get the number of texture layers.

2013-12-10 Thread Francisco Jerez
Matt Turner matts...@gmail.com writes: On Tue, Dec 10, 2013 at 1:31 PM, Brian Paul bri...@vmware.com wrote: On 12/10/2013 11:06 AM, Francisco Jerez wrote: Paul Berry stereotype...@gmail.com writes: On 10 December 2013 08:42, Francisco Jerez curroje...@riseup.net wrote: Brian Paul

Re: [Mesa-dev] [PATCH] mesa: Define helper function to get the number of texture layers.

2013-12-10 Thread Matt Turner
On Tue, Dec 10, 2013 at 5:55 PM, Francisco Jerez curroje...@riseup.net wrote: It just seems annoying and unnecessary to me to have to repeat the same pattern before each use of unreachable(). If by definition the unreachable macro wants to be accompanied with an assert, why don't we save

Re: [Mesa-dev] [PATCH] mesa: Define helper function to get the number of texture layers.

2013-12-09 Thread Brian Paul
On 12/07/2013 06:17 PM, Francisco Jerez wrote: And to check if it can have layers at all. This will be used by the implementation of ARB_shader_image_load_store. --- src/mesa/main/teximage.c | 85 src/mesa/main/teximage.h | 6 2 files

Re: [Mesa-dev] [PATCH] mesa: Define helper function to get the number of texture layers.

2013-12-09 Thread Paul Berry
On 7 December 2013 17:17, Francisco Jerez curroje...@riseup.net wrote: And to check if it can have layers at all. This will be used by the implementation of ARB_shader_image_load_store. --- src/mesa/main/teximage.c | 85

[Mesa-dev] [PATCH] mesa: Define helper function to get the number of texture layers.

2013-12-07 Thread Francisco Jerez
And to check if it can have layers at all. This will be used by the implementation of ARB_shader_image_load_store. --- src/mesa/main/teximage.c | 85 src/mesa/main/teximage.h | 6 2 files changed, 91 insertions(+) diff --git