Hello,
Thanks for your reply.
Yes you are right.
The new code was added 7 days ago)
Regards,
Andrii.
On Tue, Sep 4, 2018 at 8:53 PM Marek Olšák wrote:
> On Mon, Sep 3, 2018 at 5:05 AM, andrey simiklit
> wrote:
> > Hello,
> >
> > I believe that this check already added inside _mesa_lookup_vao:
On Mon, Sep 3, 2018 at 5:05 AM, andrey simiklit
wrote:
> Hello,
>
> I believe that this check already added inside _mesa_lookup_vao:
>
>>_mesa_lookup_vao(struct gl_context *ctx, GLuint id)
>>{
>> if (id == 0) {
>> return NULL;
>> } else {
>> ...
>>}
Your Mesa code is outdated.
Hello,
I believe that this check already added inside _mesa_lookup_vao:
>_mesa_lookup_vao(struct gl_context *ctx, GLuint id)
>{
> if (id == 0) {
> return NULL;
> } else {
> ...
>}
I guess that the '_mesa_lookup_vao' function returns NULL for zero indexes.
So we will never pass
On 08/30/2018 07:42 PM, Marek Olšák wrote:
> Sadly, there are no tests for this.
Ok... I just sent one to the piglit list. It should be easy enough to
create a few more for other glDeleteFoo functions. I'll save that for
during boring meetings. ;)
> Marek
>
> On Thu, Aug 30, 2018 at 6:24 PM,
Sadly, there are no tests for this.
Marek
On Thu, Aug 30, 2018 at 6:24 PM, Ian Romanick wrote:
> This patch is
>
> Reviewed-by: Ian Romanick
>
> Is there a piglit test? I wonder how many other glDeleteFoo functions
> mishandle the id=0 case. :(
>
> On 08/30/2018 12:16 PM, Marek Olšák wrote:
This patch is
Reviewed-by: Ian Romanick
Is there a piglit test? I wonder how many other glDeleteFoo functions
mishandle the id=0 case. :(
On 08/30/2018 12:16 PM, Marek Olšák wrote:
> From: Marek Olšák
>
> This fixes a firefox crash.
>
> Fixes: 781a78914c798dc64005b37c6ca1224ce06803fc
> ---
From: Marek Olšák
This fixes a firefox crash.
Fixes: 781a78914c798dc64005b37c6ca1224ce06803fc
---
src/mesa/main/arrayobj.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/mesa/main/arrayobj.c b/src/mesa/main/arrayobj.c
index a23031fe182..6e0665c0e5d 100644
---
