Re: [Mesa-dev] [PATCH] nir: make various getters take const pointers

2017-06-09 Thread Connor Abbott
Reviewed-by: Connor Abbott On Tue, Jun 6, 2017 at 4:25 PM, Grazvydas Ignotas wrote: > This will allow to constify other things. > > Signed-off-by: Grazvydas Ignotas > --- > src/compiler/nir/nir.h | 25

Re: [Mesa-dev] [PATCH] nir: make various getters take const pointers

2017-06-09 Thread Eric Engestrom
On Friday, 2017-06-09 20:23:04 +0300, Grazvydas Ignotas wrote: > Ping. Boring patch, should be easy to review or NAK. Don't know anything about NIR, so no clue if it's a good idea, but I personally like `const` (I think it should've been the default :P) and this patch looks good to me:

Re: [Mesa-dev] [PATCH] nir: make various getters take const pointers

2017-06-09 Thread Grazvydas Ignotas
Ping. Boring patch, should be easy to review or NAK. On Wed, Jun 7, 2017 at 2:25 AM, Grazvydas Ignotas wrote: > This will allow to constify other things. > > Signed-off-by: Grazvydas Ignotas > --- > src/compiler/nir/nir.h | 25

[Mesa-dev] [PATCH] nir: make various getters take const pointers

2017-06-06 Thread Grazvydas Ignotas
This will allow to constify other things. Signed-off-by: Grazvydas Ignotas --- src/compiler/nir/nir.h | 25 + src/compiler/nir/nir_lower_io.c | 2 +- 2 files changed, 14 insertions(+), 13 deletions(-) diff --git a/src/compiler/nir/nir.h