Re: [Mesa-dev] [PATCH] st/vdpau: use bicubic filter for scaling

Andy Furniss wrote: re-testing with an unpatched mesa and return false after PREFERS I see the same. s/w decode mplayer or mpv will segfault - bt below. No asserts with debug build of mesa. Sometimes/depending on input file it doesn't instantly segfault brief output is corrupt and I get 00s

Re: [Mesa-dev] [PATCH] st/vdpau: use bicubic filter for scaling

Christian König wrote: Am 21.06.2016 um 23:51 schrieb Andy Furniss: Andy Furniss wrote: Nayan Deshmukh wrote: I forgot to CC the list, so I am attaching our conversation here. Also probably my R7 M265 uses a progressive shader. OK, maybe that could be it. I may be able to try progressive,

Re: [Mesa-dev] [PATCH] st/vdpau: use bicubic filter for scaling

Am 21.06.2016 um 23:51 schrieb Andy Furniss: Andy Furniss wrote: Nayan Deshmukh wrote: I forgot to CC the list, so I am attaching our conversation here. Also probably my R7 M265 uses a progressive shader. OK, maybe that could be it. I may be able to try progressive, but need to remember

Re: [Mesa-dev] [PATCH] st/vdpau: use bicubic filter for scaling

Secondly, I also need to set destination_rect clip. I am not yet sure how that could be done. See how clipping is done in the compositor, function vl_compositor_render() and vl_compositor_set_dst_clip(). Basically you just use a scissor state to limit where on the surface we are going to

Re: [Mesa-dev] [PATCH] st/vdpau: use bicubic filter for scaling

Hi Andy, Thanks for trying it. I figured out that there are some problems in the patch. Firstly, I need to send a u_rect to bicubic_filter_render to take care of the destination_video_rect, as to avoid writing on the entire surface. Secondly, I also need to set destination_rect clip. I am not

Re: [Mesa-dev] [PATCH] st/vdpau: use bicubic filter for scaling

Andy Furniss wrote: Nayan Deshmukh wrote: I forgot to CC the list, so I am attaching our conversation here. Also probably my R7 M265 uses a progressive shader. OK, maybe that could be it. I may be able to try progressive, but need to remember what to change... Seems I can't test

Re: [Mesa-dev] [PATCH] st/vdpau: use bicubic filter for scaling

Nayan Deshmukh wrote: I forgot to CC the list, so I am attaching our conversation here. Also probably my R7 M265 uses a progressive shader. OK, maybe that could be it. I may be able to try progressive, but need to remember what to change... I have done it before when testing 4:2:2 (which

Re: [Mesa-dev] [PATCH] st/vdpau: use bicubic filter for scaling

I forgot to CC the list, so I am attaching our conversation here. Also probably my R7 M265 uses a progressive shader. Regards, Nayan. Nayan Deshmukh wrote: > Hi Andy, > > I am not sure why it's not working. It is working on my R7 M265. > > Is it working on switching to full screen? > > Have you

Re: [Mesa-dev] [PATCH] st/vdpau: use bicubic filter for scaling

Nayan Deshmukh wrote: Hi Andy, I forgot to change the feature in query.c, which is responsible for the information about the capabilities of the mixer. I'll send the patch with change. Ok, I tried the new patch and with mplayer or mpv the output is corrupted. I am using R9285 tonga.

Re: [Mesa-dev] [PATCH] st/vdpau: use bicubic filter for scaling

Hi Andy, I forgot to change the feature in query.c, which is responsible for the information about the capabilities of the mixer. I'll send the patch with change. Thanks. Regards, Nayan. On Wed, Jun 22, 2016 at 12:13 AM, Andy Furniss wrote: > Nayan Deshmukh wrote: > >>

Re: [Mesa-dev] [PATCH] st/vdpau: use bicubic filter for scaling

Nayan Deshmukh wrote: use bicubic filtering as high quality scaling L1. Nice, but it doesn't show up in vdpauinfo as a "y". What player/options are you using to test this? Thanks. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

[Mesa-dev] [PATCH] st/vdpau: use bicubic filter for scaling

use bicubic filtering as high quality scaling L1. v2: fix a typo and add a newline to code v3: -render the unscaled image on a temporary surface -apply noise reduction and sharpness filter on unscaled surface -render the final scaled surface using bicubic interpolation

Re: [Mesa-dev] [PATCH] st/vdpau: use bicubic filter for scaling

I don't understand the compositor code fully yet. How can I create a unscaled image with it? You allocate a temporary surface with the original size of the input video surface. Then call vl_compositor_render() with the temporary surface instead of the real destination. This is what we should

Re: [Mesa-dev] [PATCH] st/vdpau: use bicubic filter for scaling

Hi Christian, Thanks for the review. I don't understand the compositor code fully yet. How can I create a unscaled image with it? Regards, Nayan. On Fri, Jun 17, 2016 at 9:15 PM, Christian König wrote: > Really nice work. I now understand where your problem is with

Re: [Mesa-dev] [PATCH] st/vdpau: use bicubic filter for scaling

Really nice work. I now understand where your problem is with the scaled surface. Please see the further comments below. Am 16.06.2016 um 20:15 schrieb Nayan Deshmukh: v2: fix a typo and add a newline to code Signed-off-by: Nayan Deshmukh ---

[Mesa-dev] [PATCH] st/vdpau: use bicubic filter for scaling

v2: fix a typo and add a newline to code Signed-off-by: Nayan Deshmukh --- src/gallium/state_trackers/vdpau/mixer.c | 53 +--- src/gallium/state_trackers/vdpau/vdpau_private.h | 6 +++ 2 files changed, 54 insertions(+), 5 deletions(-)