Re: [Mesa-dev] [PATCH] swr/rast: adjust std::string usage to fix build

2017-06-26 Thread Cherniak, Bruce
Reviewed-by: Bruce Cherniak > On Jun 26, 2017, at 9:34 AM, Eric Engestrom wrote: > > On Monday, 2017-06-26 09:03:13 -0500, Tim Rowley wrote: >> Some combinations of c++ compilers and standard libraries had problems >> with the

Re: [Mesa-dev] [PATCH] swr/rast: adjust std::string usage to fix build

2017-06-26 Thread Eric Engestrom
On Monday, 2017-06-26 09:03:13 -0500, Tim Rowley wrote: > Some combinations of c++ compilers and standard libraries had problems > with the string::replace code we were using previously. > > This should fix the travis-ci system. Yup, confirmed: https://travis-ci.org/1ace/mesa/builds/247116248

[Mesa-dev] [PATCH] swr/rast: adjust std::string usage to fix build

2017-06-26 Thread Tim Rowley
Some combinations of c++ compilers and standard libraries had problems with the string::replace code we were using previously. This should fix the travis-ci system. --- .../drivers/swr/rasterizer/codegen/templates/gen_knobs.cpp | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-)