Re: [Mesa-dev] [PATCH 0/6] Per driver pci id lists

2011-06-06 Thread Alex Deucher
On Mon, Jun 6, 2011 at 11:49 AM, Benjamin Franzke benjaminfran...@googlemail.com wrote: We need pci id to driver-name mapping for drm and wayland platforms in egl_dri2 and egl_gallium. egl_dri2 holds a own list, which is redundant with the information thats already stored in the drivers.

Re: [Mesa-dev] [PATCH 0/6] Per driver pci id lists

2011-06-06 Thread Benjamin Franzke
Well radeon_drm_public.h declares radeon_drm_winsys_create(), but yea is_r3xx should be replaced. Patch attached. 2011/6/6 Alex Deucher alexdeuc...@gmail.com: On Mon, Jun 6, 2011 at 11:49 AM, Benjamin Franzke benjaminfran...@googlemail.com wrote: We need pci id to driver-name mapping for drm

Re: [Mesa-dev] [PATCH 0/6] Per driver pci id lists

2011-06-06 Thread Marek Olšák
Could you put the PCI IDs in a better place than src/mesa? How about src/common? Or something like that. Marek On Mon, Jun 6, 2011 at 5:49 PM, Benjamin Franzke benjaminfran...@googlemail.com wrote: We need pci id to driver-name mapping for drm and wayland platforms in egl_dri2 and egl_gallium.

Re: [Mesa-dev] [PATCH 0/6] Per driver pci id lists

2011-06-06 Thread Corbin Simpson
On Mon, Jun 6, 2011 at 9:33 AM, Benjamin Franzke benjaminfran...@googlemail.com wrote: Well radeon_drm_public.h declares radeon_drm_winsys_create(), but yea is_r3xx should be replaced. Patch attached. I remember writing is_r3xx() way back when and feeling like it was a horrible horrible hack.

Re: [Mesa-dev] [PATCH 0/6] Per driver pci id lists

2011-06-06 Thread Alex Deucher
On Mon, Jun 6, 2011 at 12:33 PM, Benjamin Franzke benjaminfran...@googlemail.com wrote: Well radeon_drm_public.h declares radeon_drm_winsys_create(), but yea is_r3xx should be replaced. Patch attached. Looks good. Thanks. Overall the patch set looks fine to me. I agree with Marek that it

Re: [Mesa-dev] [PATCH 0/6] Per driver pci id lists

2011-06-06 Thread Benjamin Franzke
2011/6/6 Alex Deucher alexdeuc...@gmail.com: Looks good.  Thanks.  Overall the patch set looks fine to me.  I agree with Marek that it might be better to put the pci ids together somewhere.  For the series: Reviewed-by: Alex Deucher alexdeuc...@gmail.com Ok, moved the lists into

Re: [Mesa-dev] [PATCH 0/6] Per driver pci id lists

2011-06-06 Thread Alex Deucher
On Mon, Jun 6, 2011 at 2:38 PM, Benjamin Franzke benjaminfran...@googlemail.com wrote: 2011/6/6 Alex Deucher alexdeuc...@gmail.com: Looks good.  Thanks.  Overall the patch set looks fine to me.  I agree with Marek that it might be better to put the pci ids together somewhere.  For the series:

Re: [Mesa-dev] [PATCH 0/6] Per driver pci id lists

2011-06-06 Thread Benjamin Franzke
2011/6/6 Alex Deucher alexdeuc...@gmail.com: Sorry, I just thought of one tricky situation.  Only r600g supports CAYMAN asics, so r600c shouldn't have the CAYMAN pci ids.  Maybe just split the CAYMAN ids out into a new header, cayman_pci_ids.h, and include both r600_pci_ids.h and

Re: [Mesa-dev] [PATCH 0/6] Per driver pci id lists

2011-06-06 Thread Alex Deucher
On Mon, Jun 6, 2011 at 3:12 PM, Benjamin Franzke benjaminfran...@googlemail.com wrote: 2011/6/6 Alex Deucher alexdeuc...@gmail.com: Sorry, I just thought of one tricky situation.  Only r600g supports CAYMAN asics, so r600c shouldn't have the CAYMAN pci ids.  Maybe just split the CAYMAN ids out