Re: [Mesa-dev] [PATCH 0/9] RadeonSI: Some shaders cleanups

2016-01-02 Thread Nicolai Hähnle
This looks much better now :) For the series: Reviewed-by: Nicolai Hähnle On 01.01.2016 09:13, Marek Olšák wrote: Hi, These are shader cleanups mostly around si_compile_llvm. You may wonder why the "move si_shader_binary_upload out of xxx" patches. They are part of

Re: [Mesa-dev] [PATCH 0/9] RadeonSI: Some shaders cleanups

2016-01-01 Thread eocallaghan
Well can't disagree with anything in this series and it certainly makes `si_shader.c' a tiny bit easier to understand for me. Hopefully not too much fallout with the debug callback patch series as they will need to be rebased on top of this :| Thus this series is, Reviewed-by: Edward

[Mesa-dev] [PATCH 0/9] RadeonSI: Some shaders cleanups

2016-01-01 Thread Marek Olšák
Hi, These are shader cleanups mostly around si_compile_llvm. You may wonder why the "move si_shader_binary_upload out of xxx" patches. They are part of my one-variant-per-shader rework, which needs a lot of restructuring. Besides this, I have 2 more series of cleanup patches, which I will

Re: [Mesa-dev] [PATCH 0/9] RadeonSI: Some shaders cleanups

2016-01-01 Thread Marek Olšák
On Fri, Jan 1, 2016 at 3:47 PM, wrote: > Well can't disagree with anything in this series and it certainly makes > `si_shader.c' a tiny bit easier to understand for me. > Hopefully not too much fallout with the debug callback patch series as they > will need to be