Re: [Mesa-dev] [PATCH 01/10] tgsi: add MEMBAR opcode to handle memoryBarrier* GLSL intrinsics

2016-01-19 Thread Marek Olšák
On Tue, Jan 19, 2016 at 3:25 AM, Ilia Mirkin wrote: > On Mon, Jan 18, 2016 at 6:06 AM, Marek Olšák wrote: >> For 1-4, >> >> Reviewed-by: Marek Olšák >> >> I'm not very familiar with the code in 2, but the changes seem reasonable. >>

Re: [Mesa-dev] [PATCH 01/10] tgsi: add MEMBAR opcode to handle memoryBarrier* GLSL intrinsics

2016-01-19 Thread Ilia Mirkin
On Tue, Jan 19, 2016 at 5:49 AM, Marek Olšák wrote: > On Tue, Jan 19, 2016 at 3:25 AM, Ilia Mirkin wrote: >> On Mon, Jan 18, 2016 at 6:06 AM, Marek Olšák wrote: >>> For 1-4, >>> >>> Reviewed-by: Marek Olšák >>> >>>

Re: [Mesa-dev] [PATCH 01/10] tgsi: add MEMBAR opcode to handle memoryBarrier* GLSL intrinsics

2016-01-19 Thread Francisco Jerez
Marek Olšák writes: > On Tue, Jan 19, 2016 at 9:09 PM, Francisco Jerez > wrote: >> Marek Olšák writes: >> >>> On Tue, Jan 19, 2016 at 3:25 AM, Ilia Mirkin wrote: On Mon, Jan 18, 2016 at 6:06 AM, Marek Olšák

Re: [Mesa-dev] [PATCH 01/10] tgsi: add MEMBAR opcode to handle memoryBarrier* GLSL intrinsics

2016-01-19 Thread Marek Olšák
On Tue, Jan 19, 2016 at 9:09 PM, Francisco Jerez wrote: > Marek Olšák writes: > >> On Tue, Jan 19, 2016 at 3:25 AM, Ilia Mirkin wrote: >>> On Mon, Jan 18, 2016 at 6:06 AM, Marek Olšák wrote: For 1-4,

Re: [Mesa-dev] [PATCH 01/10] tgsi: add MEMBAR opcode to handle memoryBarrier* GLSL intrinsics

2016-01-19 Thread Francisco Jerez
Marek Olšák writes: > On Tue, Jan 19, 2016 at 3:25 AM, Ilia Mirkin wrote: >> On Mon, Jan 18, 2016 at 6:06 AM, Marek Olšák wrote: >>> For 1-4, >>> >>> Reviewed-by: Marek Olšák >>> >>> I'm not very familiar with the

Re: [Mesa-dev] [PATCH 01/10] tgsi: add MEMBAR opcode to handle memoryBarrier* GLSL intrinsics

2016-01-18 Thread Marek Olšák
For 1-4, Reviewed-by: Marek Olšák I'm not very familiar with the code in 2, but the changes seem reasonable. Also, and I know this is not your mistake, but still, mtypes.h has: struct gl_atomic_buffer_binding AtomicBufferBindings[MAX_COMBINED_ATOMIC_BUFFERS]; But

Re: [Mesa-dev] [PATCH 01/10] tgsi: add MEMBAR opcode to handle memoryBarrier* GLSL intrinsics

2016-01-18 Thread Ilia Mirkin
On Mon, Jan 18, 2016 at 6:06 AM, Marek Olšák wrote: > For 1-4, > > Reviewed-by: Marek Olšák > > I'm not very familiar with the code in 2, but the changes seem reasonable. > > Also, and I know this is not your mistake, but still, mtypes.h has: > > struct

[Mesa-dev] [PATCH 01/10] tgsi: add MEMBAR opcode to handle memoryBarrier* GLSL intrinsics

2016-01-17 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/gallium/auxiliary/tgsi/tgsi_info.c | 2 +- src/gallium/docs/source/tgsi.rst | 17 + src/gallium/include/pipe/p_shader_tokens.h | 2 +- 3 files changed, 19 insertions(+), 2 deletions(-) diff --git