Re: [Mesa-dev] [PATCH 01/13] Add ES 3 handling to get.c and get_hash_generator.py

2012-12-11 Thread Ian Romanick
On 12/10/2012 04:06 PM, Jordan Justen wrote: On Mon, Dec 10, 2012 at 2:28 PM, Matt Turner matts...@gmail.com wrote: @@ -966,6 +973,15 @@ find_value(const char *func, GLenum pname, void **p, union value *v) int api; api = ctx-API; + /* We index into the table_set[] list of per-API

Re: [Mesa-dev] [PATCH 01/13] Add ES 3 handling to get.c and get_hash_generator.py

2012-12-11 Thread Ian Romanick
On 12/10/2012 02:28 PM, Matt Turner wrote: Other than the comments on 6, 11, and 12, the series is Reviewed-by: Ian Romanick ian.d.roman...@intel.com --- src/mesa/main/get.c | 16 src/mesa/main/get_hash_generator.py |8 +++-

Re: [Mesa-dev] [PATCH 01/13] Add ES 3 handling to get.c and get_hash_generator.py

2012-12-11 Thread Kenneth Graunke
On 12/11/2012 11:04 AM, Ian Romanick wrote: On 12/10/2012 04:06 PM, Jordan Justen wrote: On Mon, Dec 10, 2012 at 2:28 PM, Matt Turner matts...@gmail.com wrote: @@ -966,6 +973,15 @@ find_value(const char *func, GLenum pname, void **p, union value *v) int api; api = ctx-API; + /* We

[Mesa-dev] [PATCH 01/13] Add ES 3 handling to get.c and get_hash_generator.py

2012-12-10 Thread Matt Turner
--- src/mesa/main/get.c | 16 src/mesa/main/get_hash_generator.py |8 +++- src/mesa/main/mtypes.h |1 + 3 files changed, 24 insertions(+), 1 deletions(-) diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c index cd239a6..146612c

Re: [Mesa-dev] [PATCH 01/13] Add ES 3 handling to get.c and get_hash_generator.py

2012-12-10 Thread Jordan Justen
On Mon, Dec 10, 2012 at 2:28 PM, Matt Turner matts...@gmail.com wrote: @@ -966,6 +973,15 @@ find_value(const char *func, GLenum pname, void **p, union value *v) int api; api = ctx-API; + /* We index into the table_set[] list of per-API hash tables using the API's +* value

Re: [Mesa-dev] [PATCH 01/13] Add ES 3 handling to get.c and get_hash_generator.py

2012-12-10 Thread Matt Turner
On Mon, Dec 10, 2012 at 4:06 PM, Jordan Justen jljus...@gmail.com wrote: On Mon, Dec 10, 2012 at 2:28 PM, Matt Turner matts...@gmail.com wrote: @@ -966,6 +973,15 @@ find_value(const char *func, GLenum pname, void **p, union value *v) int api; api = ctx-API; + /* We index into the