Re: [Mesa-dev] [PATCH 01/17] i965/miptree: Fix handling of uninitialized MCS buffers

2018-05-08 Thread Jason Ekstrand
On Tue, May 8, 2018 at 3:54 PM, Nanley Chery wrote: > On Tue, May 08, 2018 at 03:33:22PM -0700, Jason Ekstrand wrote: > > On Thu, May 3, 2018 at 12:03 PM, Nanley Chery > wrote: > > > > > Before this patch, if we failed to initialize an MCS buffer,

Re: [Mesa-dev] [PATCH 01/17] i965/miptree: Fix handling of uninitialized MCS buffers

2018-05-08 Thread Nanley Chery
On Tue, May 08, 2018 at 03:33:22PM -0700, Jason Ekstrand wrote: > On Thu, May 3, 2018 at 12:03 PM, Nanley Chery wrote: > > > Before this patch, if we failed to initialize an MCS buffer, we'd > > end up in a state in which the miptree thinks it has an MCS buffer, > > but

Re: [Mesa-dev] [PATCH 01/17] i965/miptree: Fix handling of uninitialized MCS buffers

2018-05-08 Thread Jason Ekstrand
On Thu, May 3, 2018 at 12:03 PM, Nanley Chery wrote: > Before this patch, if we failed to initialize an MCS buffer, we'd > end up in a state in which the miptree thinks it has an MCS buffer, > but doesn't. We also leaked the clear_color_bo if it existed. > > With this

Re: [Mesa-dev] [PATCH 01/17] i965/miptree: Fix handling of uninitialized MCS buffers

2018-05-07 Thread Nanley Chery
On Mon, May 07, 2018 at 09:49:01AM +0300, Tapani Pälli wrote: > > On 05/04/2018 05:59 PM, Nanley Chery wrote: > > On Fri, May 04, 2018 at 09:03:32AM +0300, Tapani Pälli wrote: > > > Hi Nanley; > > > > > > > Hey Tapani, > > > > > On 05/03/2018 10:03 PM, Nanley Chery wrote: > > > > Before this

Re: [Mesa-dev] [PATCH 01/17] i965/miptree: Fix handling of uninitialized MCS buffers

2018-05-07 Thread Tapani Pälli
On 05/04/2018 05:59 PM, Nanley Chery wrote: On Fri, May 04, 2018 at 09:03:32AM +0300, Tapani Pälli wrote: Hi Nanley; Hey Tapani, On 05/03/2018 10:03 PM, Nanley Chery wrote: Before this patch, if we failed to initialize an MCS buffer, we'd end up in a state in which the miptree thinks it

Re: [Mesa-dev] [PATCH 01/17] i965/miptree: Fix handling of uninitialized MCS buffers

2018-05-04 Thread Nanley Chery
On Fri, May 04, 2018 at 09:03:32AM +0300, Tapani Pälli wrote: > Hi Nanley; > Hey Tapani, > On 05/03/2018 10:03 PM, Nanley Chery wrote: > > Before this patch, if we failed to initialize an MCS buffer, we'd > > end up in a state in which the miptree thinks it has an MCS buffer, > > but doesn't.

Re: [Mesa-dev] [PATCH 01/17] i965/miptree: Fix handling of uninitialized MCS buffers

2018-05-04 Thread Tapani Pälli
Hi Nanley; On 05/03/2018 10:03 PM, Nanley Chery wrote: Before this patch, if we failed to initialize an MCS buffer, we'd end up in a state in which the miptree thinks it has an MCS buffer, but doesn't. We also leaked the clear_color_bo if it existed. With this patch, we now free the miptree

[Mesa-dev] [PATCH 01/17] i965/miptree: Fix handling of uninitialized MCS buffers

2018-05-03 Thread Nanley Chery
Before this patch, if we failed to initialize an MCS buffer, we'd end up in a state in which the miptree thinks it has an MCS buffer, but doesn't. We also leaked the clear_color_bo if it existed. With this patch, we now free the miptree aux buffer resources and let intel_miptree_alloc_mcs() know