Re: [Mesa-dev] [PATCH 03/11] mesa: Add state data structures requried for ARB_shader_image_load_store.

2013-12-09 Thread Paul Berry
On 7 December 2013 17:12, Francisco Jerez curroje...@riseup.net wrote: Paul Berry stereotype...@gmail.com writes: With those changes, this patch is: Reviewed-by: Paul Berry stereotype...@gmail.com I think I've taken into account all your comments here [1], and I've changed the value

Re: [Mesa-dev] [PATCH 03/11] mesa: Add state data structures requried for ARB_shader_image_load_store.

2013-12-07 Thread Francisco Jerez
Paul Berry stereotype...@gmail.com writes: On 24 November 2013 21:00, Francisco Jerez curroje...@riseup.net wrote: [...] @@ -175,6 +175,7 @@ #define MAX_COMBINED_ATOMIC_BUFFERS(MAX_UNIFORM_BUFFERS * 6) /* Size of an atomic counter in bytes according to ARB_shader_atomic_counters */

Re: [Mesa-dev] [PATCH 03/11] mesa: Add state data structures requried for ARB_shader_image_load_store.

2013-12-06 Thread Paul Berry
On 24 November 2013 21:00, Francisco Jerez curroje...@riseup.net wrote: --- src/mesa/main/config.h | 1 + src/mesa/main/dd.h | 1 + src/mesa/main/mtypes.h | 100 + src/mesa/main/texobj.c | 1 + 4 files changed, 103 insertions(+)

Re: [Mesa-dev] [PATCH 03/11] mesa: Add state data structures requried for ARB_shader_image_load_store.

2013-11-25 Thread Francisco Jerez
Chris Forbes chr...@ijw.co.nz writes: In the commit message, s/requried/required/ Does holding onto the whole texture object make things easier? I had assumed you could get by just referencing the right gl_texture_image, but maybe that doesn't work out. Yes, it does for many reasons:

Re: [Mesa-dev] [PATCH 03/11] mesa: Add state data structures requried for ARB_shader_image_load_store.

2013-11-25 Thread Chris Forbes
That makes good sense. On Tue, Nov 26, 2013 at 6:45 AM, Francisco Jerez curroje...@riseup.net wrote: Chris Forbes chr...@ijw.co.nz writes: In the commit message, s/requried/required/ Does holding onto the whole texture object make things easier? I had assumed you could get by just

[Mesa-dev] [PATCH 03/11] mesa: Add state data structures requried for ARB_shader_image_load_store.

2013-11-24 Thread Francisco Jerez
--- src/mesa/main/config.h | 1 + src/mesa/main/dd.h | 1 + src/mesa/main/mtypes.h | 100 + src/mesa/main/texobj.c | 1 + 4 files changed, 103 insertions(+) diff --git a/src/mesa/main/config.h b/src/mesa/main/config.h index

Re: [Mesa-dev] [PATCH 03/11] mesa: Add state data structures requried for ARB_shader_image_load_store.

2013-11-24 Thread Chris Forbes
In the commit message, s/requried/required/ Does holding onto the whole texture object make things easier? I had assumed you could get by just referencing the right gl_texture_image, but maybe that doesn't work out. On Mon, Nov 25, 2013 at 6:00 PM, Francisco Jerez curroje...@riseup.net wrote: