Re: [Mesa-dev] [PATCH 03/11] st/mesa: implement GL_ATI_fragment_shader

2015-12-16 Thread Ilia Mirkin
On Wed, Dec 16, 2015 at 5:28 PM, Miklós Máté wrote: >>> + if (srcReg->argMod & GL_NEGATE_BIT_ATI) { >>> + struct ureg_src modsrc[2]; >>> + modsrc[0] = ureg_src(arg); >>> + modsrc[1] = ureg_imm1f(t->ureg, -1.0); >>> + >>> + emit_insn(t, TGSI_OPCODE_MUL, , 1,

Re: [Mesa-dev] [PATCH 03/11] st/mesa: implement GL_ATI_fragment_shader

2015-12-16 Thread Roland Scheidegger
Am 16.12.2015 um 23:40 schrieb Ilia Mirkin: > On Tue, Dec 15, 2015 at 6:05 PM, Miklós Máté wrote: >> + } else if (desc->special == 3) { >> + src[0] = args[0]; >> + src[1] = args[1]; >> + src[2] = ureg_swizzle(args[2], >> +TGSI_SWIZZLE_Z,

Re: [Mesa-dev] [PATCH 03/11] st/mesa: implement GL_ATI_fragment_shader

2015-12-16 Thread Ilia Mirkin
On Tue, Dec 15, 2015 at 6:05 PM, Miklós Máté wrote: > + } else if (desc->special == 3) { > + src[0] = args[0]; > + src[1] = args[1]; > + src[2] = ureg_swizzle(args[2], > +TGSI_SWIZZLE_Z, TGSI_SWIZZLE_Z, TGSI_SWIZZLE_Z, TGSI_SWIZZLE_Z); > +

Re: [Mesa-dev] [PATCH 03/11] st/mesa: implement GL_ATI_fragment_shader

2015-12-16 Thread Miklós Máté
Thank you for your review. See my replies inline. On 12/16/2015 05:26 PM, Marek Olšák wrote: On Wed, Dec 16, 2015 at 12:05 AM, Miklós Máté wrote: --- src/mesa/Makefile.sources | 1 + src/mesa/state_tracker/st_atifs_to_tgsi.c | 798

Re: [Mesa-dev] [PATCH 03/11] st/mesa: implement GL_ATI_fragment_shader

2015-12-16 Thread Miklós Máté
On 12/16/2015 11:40 PM, Ilia Mirkin wrote: On Tue, Dec 15, 2015 at 6:05 PM, Miklós Máté wrote: + } else if (desc->special == 3) { + src[0] = args[0]; + src[1] = args[1]; + src[2] = ureg_swizzle(args[2], +TGSI_SWIZZLE_Z, TGSI_SWIZZLE_Z,

Re: [Mesa-dev] [PATCH 03/11] st/mesa: implement GL_ATI_fragment_shader

2015-12-16 Thread Miklós Máté
On 12/16/2015 01:40 AM, Ilia Mirkin wrote: Hardly a complete review, but a handful of comments: Thank you for your comments. See my replies inline. On Tue, Dec 15, 2015 at 6:05 PM, Miklós Máté wrote: --- src/mesa/Makefile.sources | 1 +

Re: [Mesa-dev] [PATCH 03/11] st/mesa: implement GL_ATI_fragment_shader

2015-12-16 Thread Marek Olšák
On Wed, Dec 16, 2015 at 12:05 AM, Miklós Máté wrote: > --- > src/mesa/Makefile.sources | 1 + > src/mesa/state_tracker/st_atifs_to_tgsi.c | 798 > ++ > src/mesa/state_tracker/st_atifs_to_tgsi.h | 49 ++ >

Re: [Mesa-dev] [PATCH 03/11] st/mesa: implement GL_ATI_fragment_shader

2015-12-15 Thread Ilia Mirkin
Hardly a complete review, but a handful of comments: On Tue, Dec 15, 2015 at 6:05 PM, Miklós Máté wrote: > --- > src/mesa/Makefile.sources | 1 + > src/mesa/state_tracker/st_atifs_to_tgsi.c | 798 > ++ >

Re: [Mesa-dev] [PATCH 03/11] st/mesa: implement GL_ATI_fragment_shader

2015-12-15 Thread Ian Romanick
On 12/15/2015 04:40 PM, Ilia Mirkin wrote: > Hardly a complete review, but a handful of comments: > > On Tue, Dec 15, 2015 at 6:05 PM, Miklós Máté wrote: >> --- >> src/mesa/Makefile.sources | 1 + >> src/mesa/state_tracker/st_atifs_to_tgsi.c | 798 >>

[Mesa-dev] [PATCH 03/11] st/mesa: implement GL_ATI_fragment_shader

2015-12-15 Thread Miklós Máté
--- src/mesa/Makefile.sources | 1 + src/mesa/state_tracker/st_atifs_to_tgsi.c | 798 ++ src/mesa/state_tracker/st_atifs_to_tgsi.h | 49 ++ src/mesa/state_tracker/st_atom_constbuf.c | 14 + src/mesa/state_tracker/st_cb_drawpixels.c | 1 +

Re: [Mesa-dev] [PATCH 03/11] st/mesa: implement GL_ATI_fragment_shader

2015-12-15 Thread Ilia Mirkin
On Dec 15, 2015 8:59 PM, "Ian Romanick" wrote: > > On 12/15/2015 05:08 PM, Ilia Mirkin wrote: > > On Tue, Dec 15, 2015 at 7:59 PM, Ian Romanick wrote: > >> On 12/15/2015 04:40 PM, Ilia Mirkin wrote: > >>> Hardly a complete review, but a handful of

Re: [Mesa-dev] [PATCH 03/11] st/mesa: implement GL_ATI_fragment_shader

2015-12-15 Thread Jason Ekstrand
On Dec 15, 2015 6:19 PM, "Ilia Mirkin" wrote: > > > On Dec 15, 2015 8:59 PM, "Ian Romanick" wrote: > > > > On 12/15/2015 05:08 PM, Ilia Mirkin wrote: > > > On Tue, Dec 15, 2015 at 7:59 PM, Ian Romanick wrote: > > >> On 12/15/2015

Re: [Mesa-dev] [PATCH 03/11] st/mesa: implement GL_ATI_fragment_shader

2015-12-15 Thread Ilia Mirkin
On Tue, Dec 15, 2015 at 7:59 PM, Ian Romanick wrote: > On 12/15/2015 04:40 PM, Ilia Mirkin wrote: >> Hardly a complete review, but a handful of comments: >> >> On Tue, Dec 15, 2015 at 6:05 PM, Miklós Máté wrote: >>> --- >>> src/mesa/Makefile.sources

Re: [Mesa-dev] [PATCH 03/11] st/mesa: implement GL_ATI_fragment_shader

2015-12-15 Thread Ian Romanick
On 12/15/2015 05:08 PM, Ilia Mirkin wrote: > On Tue, Dec 15, 2015 at 7:59 PM, Ian Romanick wrote: >> On 12/15/2015 04:40 PM, Ilia Mirkin wrote: >>> Hardly a complete review, but a handful of comments: >>> >>> On Tue, Dec 15, 2015 at 6:05 PM, Miklós Máté