Re: [Mesa-dev] [PATCH 04/16] glsl: Add is_{matrix, record, interface}_or_array_of predicates

2014-07-24 Thread Timothy Arceri
On Wed, 2014-07-23 at 15:23 -0700, Ian Romanick wrote: On 07/21/2014 08:03 PM, Timothy Arceri wrote: On Mon, 2014-07-21 at 14:04 -0700, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com There are a bunch of places, especially in the UBO code, where we check whether

Re: [Mesa-dev] [PATCH 04/16] glsl: Add is_{matrix, record, interface}_or_array_of predicates

2014-07-23 Thread Ian Romanick
On 07/21/2014 08:03 PM, Timothy Arceri wrote: On Mon, 2014-07-21 at 14:04 -0700, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com There are a bunch of places, especially in the UBO code, where we check whether something is a matrix (or record) when we actually want to know if

[Mesa-dev] [PATCH 04/16] glsl: Add is_{matrix, record, interface}_or_array_of predicates

2014-07-21 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com There are a bunch of places, especially in the UBO code, where we check whether something is a matrix (or record) when we actually want to know if it a matrix or an array of matrices (ditto for records). This will be used in later patches in this

Re: [Mesa-dev] [PATCH 04/16] glsl: Add is_{matrix, record, interface}_or_array_of predicates

2014-07-21 Thread Timothy Arceri
On Mon, 2014-07-21 at 14:04 -0700, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com There are a bunch of places, especially in the UBO code, where we check whether something is a matrix (or record) when we actually want to know if it a matrix or an array of matrices (ditto for