Re: [Mesa-dev] [PATCH 04/17] i965/miptree: Initialize the indirect clear color to zero

2018-05-16 Thread Nanley Chery
On Wed, May 16, 2018 at 09:02:51AM +0300, Pohjolainen, Topi wrote: > On Tue, May 08, 2018 at 02:05:37PM -0700, Nanley Chery wrote: > > On Tue, May 08, 2018 at 08:31:39AM +0300, Pohjolainen, Topi wrote: > > > On Mon, May 07, 2018 at 10:11:39AM -0700, Nanley Chery wrote: > > > > On Mon, May 07, 2018

Re: [Mesa-dev] [PATCH 04/17] i965/miptree: Initialize the indirect clear color to zero

2018-05-16 Thread Pohjolainen, Topi
On Tue, May 08, 2018 at 02:05:37PM -0700, Nanley Chery wrote: > On Tue, May 08, 2018 at 08:31:39AM +0300, Pohjolainen, Topi wrote: > > On Mon, May 07, 2018 at 10:11:39AM -0700, Nanley Chery wrote: > > > On Mon, May 07, 2018 at 11:30:15AM +0300, Pohjolainen, Topi wrote: > > > > On Thu, May 03, 2018

Re: [Mesa-dev] [PATCH 04/17] i965/miptree: Initialize the indirect clear color to zero

2018-05-08 Thread Jason Ekstrand
On Tue, May 8, 2018 at 3:41 PM, Jason Ekstrand wrote: > On Thu, May 3, 2018 at 12:03 PM, Nanley Chery > wrote: > >> The indirect clear color isn't correctly tracked in >> intel_miptree::fast_clear_color. The initial value of ::fast_clear_color >> is

Re: [Mesa-dev] [PATCH 04/17] i965/miptree: Initialize the indirect clear color to zero

2018-05-08 Thread Jason Ekstrand
On Thu, May 3, 2018 at 12:03 PM, Nanley Chery wrote: > The indirect clear color isn't correctly tracked in > intel_miptree::fast_clear_color. The initial value of ::fast_clear_color > is zero, while that of the indirect clear color is undefined or > non-zero. > > Topi

Re: [Mesa-dev] [PATCH 04/17] i965/miptree: Initialize the indirect clear color to zero

2018-05-08 Thread Nanley Chery
On Tue, May 08, 2018 at 08:31:39AM +0300, Pohjolainen, Topi wrote: > On Mon, May 07, 2018 at 10:11:39AM -0700, Nanley Chery wrote: > > On Mon, May 07, 2018 at 11:30:15AM +0300, Pohjolainen, Topi wrote: > > > On Thu, May 03, 2018 at 12:03:51PM -0700, Nanley Chery wrote: > > > > The indirect clear

Re: [Mesa-dev] [PATCH 04/17] i965/miptree: Initialize the indirect clear color to zero

2018-05-07 Thread Pohjolainen, Topi
On Mon, May 07, 2018 at 10:11:39AM -0700, Nanley Chery wrote: > On Mon, May 07, 2018 at 11:30:15AM +0300, Pohjolainen, Topi wrote: > > On Thu, May 03, 2018 at 12:03:51PM -0700, Nanley Chery wrote: > > > The indirect clear color isn't correctly tracked in > > > intel_miptree::fast_clear_color. The

Re: [Mesa-dev] [PATCH 04/17] i965/miptree: Initialize the indirect clear color to zero

2018-05-07 Thread Nanley Chery
On Mon, May 07, 2018 at 11:30:15AM +0300, Pohjolainen, Topi wrote: > On Thu, May 03, 2018 at 12:03:51PM -0700, Nanley Chery wrote: > > The indirect clear color isn't correctly tracked in > > intel_miptree::fast_clear_color. The initial value of ::fast_clear_color > > is zero, while that of the

Re: [Mesa-dev] [PATCH 04/17] i965/miptree: Initialize the indirect clear color to zero

2018-05-07 Thread Pohjolainen, Topi
On Thu, May 03, 2018 at 12:03:51PM -0700, Nanley Chery wrote: > The indirect clear color isn't correctly tracked in > intel_miptree::fast_clear_color. The initial value of ::fast_clear_color > is zero, while that of the indirect clear color is undefined or > non-zero. > > Topi Pohjolainen

[Mesa-dev] [PATCH 04/17] i965/miptree: Initialize the indirect clear color to zero

2018-05-03 Thread Nanley Chery
The indirect clear color isn't correctly tracked in intel_miptree::fast_clear_color. The initial value of ::fast_clear_color is zero, while that of the indirect clear color is undefined or non-zero. Topi Pohjolainen discovered this issue with MCS buffers. This issue is apparent when fast-clearing