Re: [Mesa-dev] [PATCH 05/12] nir: rename global/local to private/function memory

2019-01-11 Thread Karol Herbst
On Fri, Jan 11, 2019 at 8:50 PM Kenneth Graunke wrote: > > On Friday, January 11, 2019 9:32:20 AM PST Eric Anholt wrote: > > Jason Ekstrand writes: > > > > > On Fri, Jan 11, 2019 at 11:11 AM Kenneth Graunke > > > wrote: > > > > > >> On Friday, January 11, 2019 8:33:41 AM PST Jason Ekstrand

Re: [Mesa-dev] [PATCH 05/12] nir: rename global/local to private/function memory

2019-01-11 Thread Jason Ekstrand
On Fri, Jan 11, 2019 at 1:55 PM Kenneth Graunke wrote: > On Friday, January 11, 2019 8:33:41 AM PST Jason Ekstrand wrote: > > I think I kind of like having "mem" be on external things. Shared is a > > little weird there because it never leaves the chip so is it mem or > shader? > > On Intel

Re: [Mesa-dev] [PATCH 05/12] nir: rename global/local to private/function memory

2019-01-11 Thread Kenneth Graunke
On Friday, January 11, 2019 8:33:41 AM PST Jason Ekstrand wrote: > I think I kind of like having "mem" be on external things. Shared is a > little weird there because it never leaves the chip so is it mem or shader? On Intel GPUs, "shared" maps to a concept called "Shared Local Memory". So I

Re: [Mesa-dev] [PATCH 05/12] nir: rename global/local to private/function memory

2019-01-11 Thread Jason Ekstrand
On Fri, Jan 11, 2019 at 1:50 PM Kenneth Graunke wrote: > On Friday, January 11, 2019 9:32:20 AM PST Eric Anholt wrote: > > Jason Ekstrand writes: > > > > > On Fri, Jan 11, 2019 at 11:11 AM Kenneth Graunke < > kenn...@whitecape.org> > > > wrote: > > > > > >> On Friday, January 11, 2019 8:33:41

Re: [Mesa-dev] [PATCH 05/12] nir: rename global/local to private/function memory

2019-01-11 Thread Kenneth Graunke
On Friday, January 11, 2019 9:32:20 AM PST Eric Anholt wrote: > Jason Ekstrand writes: > > > On Fri, Jan 11, 2019 at 11:11 AM Kenneth Graunke > > wrote: > > > >> On Friday, January 11, 2019 8:33:41 AM PST Jason Ekstrand wrote: > >> > On Fri, Jan 11, 2019 at 10:19 AM Kenneth Graunke wrote: > >>

Re: [Mesa-dev] [PATCH 05/12] nir: rename global/local to private/function memory

2019-01-11 Thread Matt Turner
On Fri, Jan 11, 2019 at 9:11 AM Kenneth Graunke wrote: > > On Friday, January 11, 2019 8:33:41 AM PST Jason Ekstrand wrote: > > On Fri, Jan 11, 2019 at 10:19 AM Kenneth Graunke wrote: > > > Those names (nir_var_func_local, nir_var_thread_local, and > > > nir_var_thread_global) make more sense to

Re: [Mesa-dev] [PATCH 05/12] nir: rename global/local to private/function memory

2019-01-11 Thread Eric Anholt
Jason Ekstrand writes: > On Fri, Jan 11, 2019 at 11:11 AM Kenneth Graunke > wrote: > >> On Friday, January 11, 2019 8:33:41 AM PST Jason Ekstrand wrote: >> > On Fri, Jan 11, 2019 at 10:19 AM Kenneth Graunke wrote: >> > > Those names (nir_var_func_local, nir_var_thread_local, and >> > >

Re: [Mesa-dev] [PATCH 05/12] nir: rename global/local to private/function memory

2019-01-11 Thread Jason Ekstrand
On Fri, Jan 11, 2019 at 11:11 AM Kenneth Graunke wrote: > On Friday, January 11, 2019 8:33:41 AM PST Jason Ekstrand wrote: > > On Fri, Jan 11, 2019 at 10:19 AM Kenneth Graunke wrote: > > > Those names (nir_var_func_local, nir_var_thread_local, and > > > nir_var_thread_global) make more sense to

Re: [Mesa-dev] [PATCH 05/12] nir: rename global/local to private/function memory

2019-01-11 Thread Kenneth Graunke
On Friday, January 11, 2019 8:33:41 AM PST Jason Ekstrand wrote: > On Fri, Jan 11, 2019 at 10:19 AM Kenneth Graunke wrote: > > Those names (nir_var_func_local, nir_var_thread_local, and > > nir_var_thread_global) make more sense to me than private/function. > > > > Another option is

Re: [Mesa-dev] [PATCH 05/12] nir: rename global/local to private/function memory

2019-01-11 Thread Karol Herbst
" On Fri, Jan 11, 2019 at 5:19 PM Kenneth Graunke wrote: > > On Wednesday, January 9, 2019 5:33:22 PM PST Ian Romanick wrote: > > On 1/8/19 9:57 PM, Kenneth Graunke wrote: > > > On Tuesday, December 4, 2018 10:26:43 AM PST Karol Herbst wrote: > > >> the naming is a bit confusing no matter how

Re: [Mesa-dev] [PATCH 05/12] nir: rename global/local to private/function memory

2019-01-11 Thread Jason Ekstrand
On Fri, Jan 11, 2019 at 10:19 AM Kenneth Graunke wrote: > On Wednesday, January 9, 2019 5:33:22 PM PST Ian Romanick wrote: > > On 1/8/19 9:57 PM, Kenneth Graunke wrote: > > > On Tuesday, December 4, 2018 10:26:43 AM PST Karol Herbst wrote: > > >> the naming is a bit confusing no matter how you

Re: [Mesa-dev] [PATCH 05/12] nir: rename global/local to private/function memory

2019-01-11 Thread Kenneth Graunke
On Wednesday, January 9, 2019 5:33:22 PM PST Ian Romanick wrote: > On 1/8/19 9:57 PM, Kenneth Graunke wrote: > > On Tuesday, December 4, 2018 10:26:43 AM PST Karol Herbst wrote: > >> the naming is a bit confusing no matter how you look at it. Within SPIR-V > >> "global" memory is memory accessible

Re: [Mesa-dev] [PATCH 05/12] nir: rename global/local to private/function memory

2019-01-10 Thread Karol Herbst
On Thu, Jan 10, 2019 at 1:06 PM Karol Herbst wrote: > > On Thu, Jan 10, 2019 at 2:33 AM Ian Romanick wrote: > > > > On 1/8/19 9:57 PM, Kenneth Graunke wrote: > > > On Tuesday, December 4, 2018 10:26:43 AM PST Karol Herbst wrote: > > >> the naming is a bit confusing no matter how you look at it.

Re: [Mesa-dev] [PATCH 05/12] nir: rename global/local to private/function memory

2019-01-10 Thread Karol Herbst
On Thu, Jan 10, 2019 at 2:33 AM Ian Romanick wrote: > > On 1/8/19 9:57 PM, Kenneth Graunke wrote: > > On Tuesday, December 4, 2018 10:26:43 AM PST Karol Herbst wrote: > >> the naming is a bit confusing no matter how you look at it. Within SPIR-V > >> "global" memory is memory accessible from all

Re: [Mesa-dev] [PATCH 05/12] nir: rename global/local to private/function memory

2019-01-09 Thread Ian Romanick
On 1/8/19 9:57 PM, Kenneth Graunke wrote: > On Tuesday, December 4, 2018 10:26:43 AM PST Karol Herbst wrote: >> the naming is a bit confusing no matter how you look at it. Within SPIR-V >> "global" memory is memory accessible from all threads. glsl "global" memory >> normally refers to shader

Re: [Mesa-dev] [PATCH 05/12] nir: rename global/local to private/function memory

2019-01-09 Thread Jason Ekstrand
On Tue, Jan 8, 2019 at 11:57 PM Kenneth Graunke wrote: > On Tuesday, December 4, 2018 10:26:43 AM PST Karol Herbst wrote: > > the naming is a bit confusing no matter how you look at it. Within SPIR-V > > "global" memory is memory accessible from all threads. glsl "global" > memory > > normally

Re: [Mesa-dev] [PATCH 05/12] nir: rename global/local to private/function memory

2019-01-09 Thread Karol Herbst
On Wed, Jan 9, 2019 at 6:57 AM Kenneth Graunke wrote: > > On Tuesday, December 4, 2018 10:26:43 AM PST Karol Herbst wrote: > > the naming is a bit confusing no matter how you look at it. Within SPIR-V > > "global" memory is memory accessible from all threads. glsl "global" memory > > normally

Re: [Mesa-dev] [PATCH 05/12] nir: rename global/local to private/function memory

2019-01-08 Thread Kenneth Graunke
On Tuesday, December 4, 2018 10:26:43 AM PST Karol Herbst wrote: > the naming is a bit confusing no matter how you look at it. Within SPIR-V > "global" memory is memory accessible from all threads. glsl "global" memory > normally refers to shader thread private memory declared at global scope. As

Re: [Mesa-dev] [PATCH 05/12] nir: rename global/local to private/function memory

2019-01-07 Thread Jason Ekstrand
Assuming it builds everywhere (probably best to double-check before pushing anything) Reviewed-by: Jason Ekstrand On Tue, Dec 4, 2018 at 12:27 PM Karol Herbst wrote: > the naming is a bit confusing no matter how you look at it. Within SPIR-V > "global" memory is memory accessible from all

[Mesa-dev] [PATCH 05/12] nir: rename global/local to private/function memory

2018-12-04 Thread Karol Herbst
the naming is a bit confusing no matter how you look at it. Within SPIR-V "global" memory is memory accessible from all threads. glsl "global" memory normally refers to shader thread private memory declared at global scope. As we already use "shared" for memory shared across all thrads of a work