...@lists.freedesktop.org] On Behalf Of
Zhang, Boyuan
Sent: July-21-16 10:52 AM
To: 'Christian König'; mesa-dev@lists.freedesktop.org
Subject: Re: [Mesa-dev] [PATCH 05/12] st/va: add encode entrypoint
>> @@ -150,7 +167,18 @@ vlVaCreateConfig(VADriverContextP ctx, VAProfile
>> profile, VAEntrypoi
>> @@ -150,7 +167,18 @@ vlVaCreateConfig(VADriverContextP ctx, VAProfile
>> profile, VAEntrypoint entrypoin
>> if (entrypoint != VAEntrypointVLD)
>> return VA_STATUS_ERROR_UNSUPPORTED_ENTRYPOINT;
>>
>> - *config_id = p;
>> +#if 0
>> + if (entrypoint == VAEntrypointEncSlice ||
Am 20.07.2016 um 20:00 schrieb Zhang, Boyuan:
>Makes sense, but I suggest that in this case we should add at least a
comment why this is still disabled.
>And it would look better if we have an "#if 0" or something like this in
the code which gets explicitly removed with the last patch.
Am 21.07.2016 um 00:13 schrieb Boyuan Zhang:
VAAPI passes PIPE_VIDEO_ENTRYPOINT_ENCODE as entry point for encoding case. We
will save this encode entry point in config. config_id was used as profile
previously. Now, config has both profile and entrypoint field, and config_id is
used to get
VAAPI passes PIPE_VIDEO_ENTRYPOINT_ENCODE as entry point for encoding case. We
will save this encode entry point in config. config_id was used as profile
previously. Now, config has both profile and entrypoint field, and config_id is
used to get the config object. Later on, we pass this
>Makes sense, but I suggest that in this case we should add at least a comment
>why this is still disabled.
>And it would look better if we have an "#if 0" or something like this in the
>code which gets explicitly removed with the last patch.
Sure, I agree. I will submit a new patch set to add
Am 20.07.2016 um 06:12 schrieb Zhang, Boyuan:
>> @@ -150,7 +167,16 @@ vlVaCreateConfig(VADriverContextP ctx, VAProfile
profile, VAEntrypoint entrypoin
>>if (entrypoint != VAEntrypointVLD)
>> return VA_STATUS_ERROR_UNSUPPORTED_ENTRYPOINT;
>>
>> - *config_id = p;
>> + if (entrypoint
>> @@ -150,7 +167,16 @@ vlVaCreateConfig(VADriverContextP ctx, VAProfile
>> profile, VAEntrypoint entrypoin
>> if (entrypoint != VAEntrypointVLD)
>> return VA_STATUS_ERROR_UNSUPPORTED_ENTRYPOINT;
>>
>> - *config_id = p;
>> + if (entrypoint == VAEntrypointEncSlice || entrypoint ==
Am 19.07.2016 um 00:43 schrieb Boyuan Zhang:
VAAPI passes PIPE_VIDEO_ENTRYPOINT_ENCODE as entry point for encoding case. We
will save this encode entry point in config. config_id was used as profile
previously. Now, config has both profile and entrypoint field, and config_id is
used to get
VAAPI passes PIPE_VIDEO_ENTRYPOINT_ENCODE as entry point for encoding case. We
will save this encode entry point in config. config_id was used as profile
previously. Now, config has both profile and entrypoint field, and config_id is
used to get the config object. Later on, we pass this
10 matches
Mail list logo