On Friday, April 29, 2016 9:15:59 AM PDT Ian Romanick wrote:
> Obligatory question: piglit tests? This series looks like a good
> solution for the problem in the bug, but I always worry that we've
> caught N-1 possible cases. That can be easier to detect from the set of
> tests.
>
> If there
Obligatory question: piglit tests? This series looks like a good
solution for the problem in the bug, but I always worry that we've
caught N-1 possible cases. That can be easier to detect from the set of
tests.
If there are more problem found later, we can fix them later. This
series is
The old visitor missed some cases. For example, it wouldn't handle
an ir_dereference_array with a vector_extract as the index.
Rather than trying to add the missing cases, just rewrite it as an
ir_rvalue_visitor. This makes it easy to replace any expression,
and is much less code.
Cc:
