Re: [Mesa-dev] [PATCH 1/2] i965: Clean up intel_batchbuffer_init().

2017-08-11 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga On Thu, 2017-08-10 at 22:52 -0700, Kenneth Graunke wrote: > Passing screen lets us get the kernel features, devinfo, and bufmgr, > without needing container_of. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102062 > Cc: Mauro Rossi

Re: [Mesa-dev] [PATCH 1/2] i965: Clean up intel_batchbuffer_init().

2017-08-11 Thread Emil Velikov
On 11 August 2017 at 06:52, Kenneth Graunke wrote: > Passing screen lets us get the kernel features, devinfo, and bufmgr, > without needing container_of. > Hmm it seems to be crashing since sample (aka brw) cannot be NULL. Which seems to be the case here. Reviewed-by: Emil

Re: [Mesa-dev] [PATCH 1/2] i965: Clean up intel_batchbuffer_init().

2017-08-11 Thread Tapani Pälli
heh I've just sent a patch that passes context (to get rid of container_of) but I can see that screen is enough, thanks for fixing this! Reviewed-by: Tapani Pälli On 08/11/2017 08:52 AM, Kenneth Graunke wrote: Passing screen lets us get the kernel features, devinfo,

[Mesa-dev] [PATCH 1/2] i965: Clean up intel_batchbuffer_init().

2017-08-10 Thread Kenneth Graunke
Passing screen lets us get the kernel features, devinfo, and bufmgr, without needing container_of. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102062 Cc: Mauro Rossi Cc: Tapani Pälli --- src/mesa/drivers/dri/i965/brw_context.c |