Re: [Mesa-dev] [PATCH 1/2] mesa: Avoid ABA problem on buffer object bind.

2011-10-24 Thread Brian Paul
On 10/23/2011 01:20 PM, Mathias Fröhlich wrote: Hi, On Sunday, October 23, 2011 17:53:53 Brian Paul wrote: Looks good. Just minor things: In other places where we have a field like this it's called DeletePending. The comment you added in _mesa_DeleteBuffersARB() is a bit hard to

Re: [Mesa-dev] [PATCH 1/2] mesa: Avoid ABA problem on buffer object bind.

2011-10-23 Thread Brian Paul
On 10/22/2011 04:57 AM, Mathias Fröhlich wrote: Hi, Make sure we do not run into the classic ABA problem on buffer object bind, reusing this name and may be never rebind since we get an new name that was just deleted and never rebound in between. The explicit rebinding to the debault object in

Re: [Mesa-dev] [PATCH 1/2] mesa: Avoid ABA problem on buffer object bind.

2011-10-23 Thread Mathias Fröhlich
Hi, On Sunday, October 23, 2011 17:53:53 Brian Paul wrote: Looks good. Just minor things: In other places where we have a field like this it's called DeletePending. The comment you added in _mesa_DeleteBuffersARB() is a bit hard to understand. If you need help, I could rewrite it for

[Mesa-dev] [PATCH 1/2] mesa: Avoid ABA problem on buffer object bind.

2011-10-22 Thread Mathias Fröhlich
Hi, Make sure we do not run into the classic ABA problem on buffer object bind, reusing this name and may be never rebind since we get an new name that was just deleted and never rebound in between. The explicit rebinding to the debault object in the current context prevents the above in the