Re: [Mesa-dev] [PATCH 1/2] svga: use switch statement in svga_shader_type()

2013-06-28 Thread Jose Fonseca
- Original Message - Safer in case the PIPE_SHADER_x tokens get renumbered (as Marek wanted to do). Renumbering PIPE_SHADER_x seems a pure time waster -- there is much more code that expects the current order -- and I see no benefit. This patch looks good nevertheles. ---

Re: [Mesa-dev] [PATCH 1/2] svga: use switch statement in svga_shader_type()

2013-06-28 Thread Marek Olšák
The renumbering only makes sense for the GLSL linker and the only reason for doing that in gallium too is that PIPE_SHADER_x must be equal to MESA_SHADER_x. Marek On Fri, Jun 28, 2013 at 4:32 PM, Jose Fonseca jfons...@vmware.com wrote: - Original Message - Safer in case the