Re: [Mesa-dev] [PATCH 1/2] vc4: Wire up core pipe_debug_callback

2018-12-20 Thread Rhys Kidd
Awesome, thanks! Apologies that I was unable to get around to looking at your feedback in the intervening period of time. On Thu, Dec 20, 2018 at 2:34 PM Eric Anholt wrote: > Eric Anholt writes: > > > [ Unknown signature status ] > > Rhys Kidd writes: > > > >> Signed-off-by: Rhys Kidd > > >

Re: [Mesa-dev] [PATCH 1/2] vc4: Wire up core pipe_debug_callback

2018-12-20 Thread Eric Anholt
Eric Anholt writes: > [ Unknown signature status ] > Rhys Kidd writes: > >> Signed-off-by: Rhys Kidd > > Does this actually do anything for us, though? Shouldn't we be hooking > up our perf_debug() calls to it? I hooked up perf_debug(), extended the commit messages, and pushed.

Re: [Mesa-dev] [PATCH 1/2] vc4: Wire up core pipe_debug_callback

2018-08-10 Thread Eric Anholt
Rhys Kidd writes: > Signed-off-by: Rhys Kidd Does this actually do anything for us, though? Shouldn't we be hooking up our perf_debug() calls to it? signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

[Mesa-dev] [PATCH 1/2] vc4: Wire up core pipe_debug_callback

2018-08-10 Thread Rhys Kidd
Signed-off-by: Rhys Kidd --- src/gallium/drivers/vc4/vc4_context.c | 13 + src/gallium/drivers/vc4/vc4_context.h | 1 + 2 files changed, 14 insertions(+) diff --git a/src/gallium/drivers/vc4/vc4_context.c b/src/gallium/drivers/vc4/vc4_context.c index 9ff39c2655..6f91d0567c 100644