Re: [Mesa-dev] [PATCH 1/3] gallium/radeon: remove separate BE path in r600_translate_colorswap

2016-02-26 Thread Marek Olšák
On Fri, Feb 26, 2016 at 12:38 PM, Oded Gabbay wrote: > On Fri, Feb 26, 2016 at 12:51 PM, Marek Olšák wrote: >> On Thu, Feb 25, 2016 at 10:09 PM, Oded Gabbay wrote: >>> After further testing, it appears there is no need for >>>

Re: [Mesa-dev] [PATCH 1/3] gallium/radeon: remove separate BE path in r600_translate_colorswap

2016-02-26 Thread Oded Gabbay
On Fri, Feb 26, 2016 at 5:03 AM, Michel Dänzer wrote: > On 26.02.2016 06:09, Oded Gabbay wrote: >> After further testing, it appears there is no need for >> separate BE path in r600_translate_colorswap() >> >> The only fix remaining is the change of the last if statement, in

Re: [Mesa-dev] [PATCH 1/3] gallium/radeon: remove separate BE path in r600_translate_colorswap

2016-02-26 Thread Oded Gabbay
On Fri, Feb 26, 2016 at 12:51 PM, Marek Olšák wrote: > On Thu, Feb 25, 2016 at 10:09 PM, Oded Gabbay wrote: >> After further testing, it appears there is no need for >> separate BE path in r600_translate_colorswap() >> >> The only fix remaining is the

Re: [Mesa-dev] [PATCH 1/3] gallium/radeon: remove separate BE path in r600_translate_colorswap

2016-02-26 Thread Marek Olšák
On Thu, Feb 25, 2016 at 10:09 PM, Oded Gabbay wrote: > After further testing, it appears there is no need for > separate BE path in r600_translate_colorswap() > > The only fix remaining is the change of the last if statement, in the 4 > channels case. Originally, it

Re: [Mesa-dev] [PATCH 1/3] gallium/radeon: remove separate BE path in r600_translate_colorswap

2016-02-25 Thread Michel Dänzer
On 26.02.2016 06:09, Oded Gabbay wrote: > After further testing, it appears there is no need for > separate BE path in r600_translate_colorswap() > > The only fix remaining is the change of the last if statement, in the 4 > channels case. Originally, it contained an invalid swizzle configuration

[Mesa-dev] [PATCH 1/3] gallium/radeon: remove separate BE path in r600_translate_colorswap

2016-02-25 Thread Oded Gabbay
After further testing, it appears there is no need for separate BE path in r600_translate_colorswap() The only fix remaining is the change of the last if statement, in the 4 channels case. Originally, it contained an invalid swizzle configuration that never got hit, in LE or BE. So the fix is