[Mesa-dev] [PATCH 1/3] glsl: Move common code out of opt_algebraic's handle_expression().

2013-10-25 Thread Eric Anholt
Matt and I had each screwed up these common required patterns recently, in ways that wouldn't have been noticed for a long time if not for code review. Just enforce it in the caller so that we don't rely on code review catching these bugs. --- src/glsl/opt_algebraic.cpp | 117

Re: [Mesa-dev] [PATCH 1/3] glsl: Move common code out of opt_algebraic's handle_expression().

2013-10-25 Thread Kenneth Graunke
On 10/25/2013 02:49 PM, Eric Anholt wrote: Matt and I had each screwed up these common required patterns recently, in ways that wouldn't have been noticed for a long time if not for code review. Just enforce it in the caller so that we don't rely on code review catching these bugs. ---