Re: [Mesa-dev] [PATCH 1/3] glsl: on UBO/SSBOs link error, the number of active blocks remains 0

2017-03-27 Thread Andres Gomez
On Sun, 2017-03-26 at 21:08 +1100, Timothy Arceri wrote: > Ok. So lets start again. :) ... > With those this is: > > Reviewed-by: Timothy Arceri I'll apply the changes. Thanks a lot for your patience during the reviewing process ☺ -- Br, Andres

Re: [Mesa-dev] [PATCH 1/3] glsl: on UBO/SSBOs link error, the number of active blocks remains 0

2017-03-26 Thread Timothy Arceri
Ok. So lets start again. :) How about changing the subject to: glsl: on UBO/SSBOs link error reset the number of active blocks to 0 On 23/02/17 19:55, Andres Gomez wrote: Commit f1293b2f9bc3 split apart buffer block arrays but introduced also the possibility of a recount of active blocks

Re: [Mesa-dev] [PATCH 1/3] glsl: on UBO/SSBOs link error, the number of active blocks remains 0

2017-03-21 Thread Andres Gomez
On Sun, 2017-03-12 at 16:34 +1100, Timothy Arceri wrote: > > On 12/03/17 12:17, Andres Gomez wrote: > > On Sun, 2017-03-12 at 10:07 +1100, Timothy Arceri wrote: > > > > > > On 12/03/17 00:29, Andres Gomez wrote: > > > > On Sat, 2017-03-11 at 23:24 +1100, Timothy Arceri wrote: > > > > > > > > >

Re: [Mesa-dev] [PATCH 1/3] glsl: on UBO/SSBOs link error, the number of active blocks remains 0

2017-03-11 Thread Timothy Arceri
On 12/03/17 12:17, Andres Gomez wrote: On Sun, 2017-03-12 at 10:07 +1100, Timothy Arceri wrote: On 12/03/17 00:29, Andres Gomez wrote: On Sat, 2017-03-11 at 23:24 +1100, Timothy Arceri wrote: On 10/03/17 18:53, Andres Gomez wrote: According with that text it would be OK to report a

Re: [Mesa-dev] [PATCH 1/3] glsl: on UBO/SSBOs link error, the number of active blocks remains 0

2017-03-11 Thread Andres Gomez
On Sun, 2017-03-12 at 10:07 +1100, Timothy Arceri wrote: > > On 12/03/17 00:29, Andres Gomez wrote: > > On Sat, 2017-03-11 at 23:24 +1100, Timothy Arceri wrote: > > > > > > On 10/03/17 18:53, Andres Gomez wrote: > > > > > > > > According with that text it would be OK to report a different

Re: [Mesa-dev] [PATCH 1/3] glsl: on UBO/SSBOs link error, the number of active blocks remains 0

2017-03-11 Thread Timothy Arceri
On 12/03/17 00:29, Andres Gomez wrote: On Sat, 2017-03-11 at 23:24 +1100, Timothy Arceri wrote: On 10/03/17 18:53, Andres Gomez wrote: According with that text it would be OK to report a different number than 0 when asking for the active UBOs to the failed link program but it still will be

Re: [Mesa-dev] [PATCH 1/3] glsl: on UBO/SSBOs link error, the number of active blocks remains 0

2017-03-11 Thread Andres Gomez
On Sat, 2017-03-11 at 23:24 +1100, Timothy Arceri wrote: > > On 10/03/17 18:53, Andres Gomez wrote: > > > > According with that text it would be OK to report a different number > > than 0 when asking for the active UBOs to the failed link program but > > it still will be not OK that, when trying

Re: [Mesa-dev] [PATCH 1/3] glsl: on UBO/SSBOs link error, the number of active blocks remains 0

2017-03-11 Thread Timothy Arceri
On 10/03/17 18:53, Andres Gomez wrote: On Fri, 2017-03-10 at 14:28 +1100, Timothy Arceri wrote: On 10/03/17 08:46, Andres Gomez wrote: On Fri, 2017-03-10 at 08:32 +1100, Timothy Arceri wrote: On 23/02/17 19:55, Andres Gomez wrote: Commit f1293b2f9bc3 split apart buffer block arrays but

Re: [Mesa-dev] [PATCH 1/3] glsl: on UBO/SSBOs link error, the number of active blocks remains 0

2017-03-09 Thread Andres Gomez
On Fri, 2017-03-10 at 14:28 +1100, Timothy Arceri wrote: > > On 10/03/17 08:46, Andres Gomez wrote: > > On Fri, 2017-03-10 at 08:32 +1100, Timothy Arceri wrote: > > > On 23/02/17 19:55, Andres Gomez wrote: > > > > Commit f1293b2f9bc3 split apart buffer block arrays but introduced > > > > also the

Re: [Mesa-dev] [PATCH 1/3] glsl: on UBO/SSBOs link error, the number of active blocks remains 0

2017-03-09 Thread Timothy Arceri
On 10/03/17 08:46, Andres Gomez wrote: On Fri, 2017-03-10 at 08:32 +1100, Timothy Arceri wrote: On 23/02/17 19:55, Andres Gomez wrote: Commit f1293b2f9bc3 split apart buffer block arrays but introduced also the possibility of a recount of active blocks

Re: [Mesa-dev] [PATCH 1/3] glsl: on UBO/SSBOs link error, the number of active blocks remains 0

2017-03-09 Thread Andres Gomez
On Fri, 2017-03-10 at 08:32 +1100, Timothy Arceri wrote: > On 23/02/17 19:55, Andres Gomez wrote: > > Commit f1293b2f9bc3 split apart buffer block arrays but introduced > > also the possibility of a recount of active > > blocks (NumUniformBlocks/NumShaderStorageBlocks) which would be > >

Re: [Mesa-dev] [PATCH 1/3] glsl: on UBO/SSBOs link error, the number of active blocks remains 0

2017-03-09 Thread Timothy Arceri
On 23/02/17 19:55, Andres Gomez wrote: Commit f1293b2f9bc3 split apart buffer block arrays but introduced also the possibility of a recount of active blocks (NumUniformBlocks/NumShaderStorageBlocks) which would be incoherent with the actual amount of active blocks

[Mesa-dev] [PATCH 1/3] glsl: on UBO/SSBOs link error, the number of active blocks remains 0

2017-02-23 Thread Andres Gomez
Commit f1293b2f9bc3 split apart buffer block arrays but introduced also the possibility of a recount of active blocks (NumUniformBlocks/NumShaderStorageBlocks) which would be incoherent with the actual amount of active blocks (UniformBlocks/ShaderStorageBlocks) in the program. This could cause a