Re: [Mesa-dev] [PATCH 1/3] intel/genxml: Make assert in gen_pack_header print a message.

Reviewed-by: Jason Ekstrand On Mon, May 7, 2018 at 1:51 PM, Caio Marcelo de Oliveira Filho < caio.olive...@intel.com> wrote: > Series is > > Reviewed-by: Caio Marcelo de Oliveira Filho > > > On Mon, May 07, 2018 at 01:40:44PM -0700, Kenneth

Re: [Mesa-dev] [PATCH 1/3] intel/genxml: Make assert in gen_pack_header print a message.

Series is Reviewed-by: Caio Marcelo de Oliveira Filho On Mon, May 07, 2018 at 01:40:44PM -0700, Kenneth Graunke wrote: > Python's assert can take both a condition and a string, which will cause > it to print the string if the assertion trips. (You can't use parens as

[Mesa-dev] [PATCH 1/3] intel/genxml: Make assert in gen_pack_header print a message.

Python's assert can take both a condition and a string, which will cause it to print the string if the assertion trips. (You can't use parens as that creates a tuple.) Doing "condition and string" works in C, but doesn't have the desired effect in Python. --- src/intel/genxml/gen_pack_header.py