Re: [Mesa-dev] [PATCH 1/4] common: Check for extensions before resolving symbols

2017-05-02 Thread Daniel Stone
Hi Eric, On 2 May 2017 at 16:05, Eric Engestrom wrote: > On Tuesday, 2017-05-02 11:52:06 +0100, Daniel Stone wrote: >> --- a/common.c >> +++ b/common.c >> @@ -1,5 +1,6 @@ >> /* >> * Copyright (c) 2017 Rob Clark >> + * Copyright © 2013 Intel

Re: [Mesa-dev] [PATCH 1/4] common: Check for extensions before resolving symbols

2017-05-02 Thread Eric Engestrom
On Tuesday, 2017-05-02 11:52:06 +0100, Daniel Stone wrote: > eglGetProcAddress is allowed to return any old garbage for symbols it > doesn't know about. To avoid any mishaps, check for the appropriate > extension presence (split into EGL client extension, EGL display > extension, and GL extension,

[Mesa-dev] [PATCH 1/4] common: Check for extensions before resolving symbols

2017-05-02 Thread Daniel Stone
eglGetProcAddress is allowed to return any old garbage for symbols it doesn't know about. To avoid any mishaps, check for the appropriate extension presence (split into EGL client extension, EGL display extension, and GL extension, checks) before we look up any symbols through it. The walk