Re: [Mesa-dev] [PATCH 1/5] i965/gen9: Don't disallow fast clear for MSRT formats matching render

s/Don't disallow/Allow/ reads much, much better. The original wording made my head hurt. :) On 11/19/2015 07:25 AM, Neil Roberts wrote: > Previously fast clear was disallowed on Gen9 for MSRTs with the claim > that some formats don't work but we didn't understand why. On further > investigation

Re: [Mesa-dev] [PATCH 1/5] i965/gen9: Don't disallow fast clear for MSRT formats matching render

Ben Widawsky writes: >> + if (brw->gen >= 9 && >> + brw_format_for_mesa_format(irb->mt->format) != >> + brw->render_target_format[irb->mt->format]) > > Could you just do > !brw->format_supported_as_render_target[irb->mt->format]? Hrm, yes, you're right,

Re: [Mesa-dev] [PATCH 1/5] i965/gen9: Don't disallow fast clear for MSRT formats matching render

> Ben Widawsky writes: > >>> + if (brw->gen >= 9 && >>> + brw_format_for_mesa_format(irb->mt->format) != >>> + brw->render_target_format[irb->mt->format]) >> >> Could you just do >> !brw->format_supported_as_render_target[irb->mt->format]? Neil Roberts

Re: [Mesa-dev] [PATCH 1/5] i965/gen9: Don't disallow fast clear for MSRT formats matching render

On Thu, Nov 19, 2015 at 04:25:17PM +0100, Neil Roberts wrote: > Previously fast clear was disallowed on Gen9 for MSRTs with the claim > that some formats don't work but we didn't understand why. On further > investigation it seems the formats that don't work are the ones where > the render surface

[Mesa-dev] [PATCH 1/5] i965/gen9: Don't disallow fast clear for MSRT formats matching render

Previously fast clear was disallowed on Gen9 for MSRTs with the claim that some formats don't work but we didn't understand why. On further investigation it seems the formats that don't work are the ones where the render surface format is being overriden to a different format than the one used for