Re: [Mesa-dev] [PATCH 1/6] gallium: use enums in p_defines.h

2016-04-17 Thread Marek Olšák
On Sun, Apr 17, 2016 at 1:22 AM, Emil Velikov wrote: > On 16 April 2016 at 22:04, Marek Olšák wrote: >> On Sat, Apr 16, 2016 at 9:40 PM, Rob Clark wrote: >>> On Sat, Apr 16, 2016 at 8:50 AM, Marek Olšák wrote:

Re: [Mesa-dev] [PATCH 1/6] gallium: use enums in p_defines.h

2016-04-17 Thread Jose Fonseca
On 16/04/16 22:51, Rob Clark wrote: On Sat, Apr 16, 2016 at 5:49 PM, Rob Clark wrote: On Sat, Apr 16, 2016 at 5:04 PM, Marek Olšák wrote: On Sat, Apr 16, 2016 at 9:40 PM, Rob Clark wrote: On Sat, Apr 16, 2016 at 8:50 AM, Marek

Re: [Mesa-dev] [PATCH 1/6] gallium: use enums in p_defines.h

2016-04-16 Thread Emil Velikov
On 16 April 2016 at 22:04, Marek Olšák wrote: > On Sat, Apr 16, 2016 at 9:40 PM, Rob Clark wrote: >> On Sat, Apr 16, 2016 at 8:50 AM, Marek Olšák wrote: >>> From: Marek Olšák >>> >>> and remove number assignments

Re: [Mesa-dev] [PATCH 1/6] gallium: use enums in p_defines.h

2016-04-16 Thread Roland Scheidegger
Makes me wonder why we didn't use enums in the first place. But I can't think of any disadvantages. Reviewed-by: Roland Scheidegger Am 16.04.2016 um 14:50 schrieb Marek Olšák: > From: Marek Olšák > > and remove number assignments which are consecutive

Re: [Mesa-dev] [PATCH 1/6] gallium: use enums in p_defines.h

2016-04-16 Thread Rob Clark
On Sat, Apr 16, 2016 at 5:49 PM, Rob Clark wrote: > On Sat, Apr 16, 2016 at 5:04 PM, Marek Olšák wrote: >> On Sat, Apr 16, 2016 at 9:40 PM, Rob Clark wrote: >>> On Sat, Apr 16, 2016 at 8:50 AM, Marek Olšák wrote:

Re: [Mesa-dev] [PATCH 1/6] gallium: use enums in p_defines.h

2016-04-16 Thread Rob Clark
On Sat, Apr 16, 2016 at 5:04 PM, Marek Olšák wrote: > On Sat, Apr 16, 2016 at 9:40 PM, Rob Clark wrote: >> On Sat, Apr 16, 2016 at 8:50 AM, Marek Olšák wrote: >>> From: Marek Olšák >>> >>> and remove number

Re: [Mesa-dev] [PATCH 1/6] gallium: use enums in p_defines.h

2016-04-16 Thread Marek Olšák
On Sat, Apr 16, 2016 at 9:40 PM, Rob Clark wrote: > On Sat, Apr 16, 2016 at 8:50 AM, Marek Olšák wrote: >> From: Marek Olšák >> >> and remove number assignments which are consecutive >> --- >> src/gallium/include/pipe/p_defines.h |

Re: [Mesa-dev] [PATCH 1/6] gallium: use enums in p_defines.h

2016-04-16 Thread Rob Clark
On Sat, Apr 16, 2016 at 8:50 AM, Marek Olšák wrote: > From: Marek Olšák > > and remove number assignments which are consecutive > --- > src/gallium/include/pipe/p_defines.h | 378 > +++ > 1 file changed, 205 insertions(+),

Re: [Mesa-dev] [PATCH 1/6] gallium: use enums in p_defines.h

2016-04-16 Thread eocallaghan
Patches 1 & 2 are, Reviewed-by: Edward O'Callaghan i`ll have to spend some time looking at the others tomorrow.. On 2016-04-16 22:50, Marek Olšák wrote: From: Marek Olšák and remove number assignments which are consecutive ---

[Mesa-dev] [PATCH 1/6] gallium: use enums in p_defines.h

2016-04-16 Thread Marek Olšák
From: Marek Olšák and remove number assignments which are consecutive --- src/gallium/include/pipe/p_defines.h | 378 +++ 1 file changed, 205 insertions(+), 173 deletions(-) diff --git a/src/gallium/include/pipe/p_defines.h