Re: [Mesa-dev] [PATCH 1/6] i965: Kill y_or_x variable in miptree tiling selection

2015-08-10 Thread Anuj Phogat
On Mon, Aug 10, 2015 at 4:15 PM, Ben Widawsky benjamin.widaw...@intel.com wrote: NOTE: The commit message is retained for posterity, however there were some changes in the code since the patch was originally written that may make the old commit message false. Starting with v4 is actually much

[Mesa-dev] [PATCH 1/6] i965: Kill y_or_x variable in miptree tiling selection

2015-08-10 Thread Ben Widawsky
NOTE: The commit message is retained for posterity, however there were some changes in the code since the patch was originally written that may make the old commit message false. Starting with v4 is actually much simpler than the original change. This patch is needed to help keep some of the

Re: [Mesa-dev] [PATCH 1/6] i965: Kill y_or_x variable in miptree tiling selection

2015-03-23 Thread Neil Roberts
Ben Widawsky benjamin.widaw...@intel.com writes: This patch actually addresses two potential issues: 1. As far as I can tell, drm_intel_gem_bo_alloc_tiled() which is invariably called, can potentially change the tiling type. Therefore, we shouldn't be checking the requested tiling type, but

Re: [Mesa-dev] [PATCH 1/6] i965: Kill y_or_x variable in miptree tiling selection

2015-03-10 Thread Anuj Phogat
On Mon, Mar 9, 2015 at 9:43 PM, Ben Widawsky benjamin.widaw...@intel.com wrote: IMHO, intel_miptree_choose_tiling() is an unfortunate incarnation because it conflates what is permitted vs. what is desirable. This makes doing any sort of fallback operations after the fact somewhat kludgey.

[Mesa-dev] [PATCH 1/6] i965: Kill y_or_x variable in miptree tiling selection

2015-03-09 Thread Ben Widawsky
IMHO, intel_miptree_choose_tiling() is an unfortunate incarnation because it conflates what is permitted vs. what is desirable. This makes doing any sort of fallback operations after the fact somewhat kludgey. The original code basically says: if we requested x XOR y-tiled, and the region