Re: [Mesa-dev] [PATCH 1/8] draw: rework hanndling of non-existing outputs in emit code

2016-01-04 Thread Brian Paul
I didn't do a detailed review, but these changes look like good clean-ups. For the series, Reviewed-by: Brian Paul On 12/21/2015 08:00 PM, srol...@vmware.com wrote: From: Roland Scheidegger Previously the code would just redirect requests for

Re: [Mesa-dev] [PATCH 1/8] draw: rework hanndling of non-existing outputs in emit code

2015-12-22 Thread Jose Fonseca
On 22/12/15 03:00, srol...@vmware.com wrote: From: Roland Scheidegger Previously the code would just redirect requests for attributes which don't exist to use output 0. Rework this to output all zeros instead which seems more useful - in particular some extensions like

Re: [Mesa-dev] [PATCH 1/8] draw: rework hanndling of non-existing outputs in emit code

2015-12-21 Thread eocallaghan
Thanks for the most comprehensive cleanup Roland and fixing that minor regression we discussed. Happy holiday's. Reviewed-by: Edward O'Callaghan On 2015-12-22 14:00, srol...@vmware.com wrote: From: Roland Scheidegger Previously the code

[Mesa-dev] [PATCH 1/8] draw: rework hanndling of non-existing outputs in emit code

2015-12-21 Thread sroland
From: Roland Scheidegger Previously the code would just redirect requests for attributes which don't exist to use output 0. Rework this to output all zeros instead which seems more useful - in particular some extensions like ARB_fragment_layer_viewport require 0 in the fs