Re: [Mesa-dev] [PATCH 11/14] mesa: add bind_frag_data_location() helper

On 28/06/17 18:39, Samuel Pitoiset wrote: Like you told me in a similar patch, we should keep "if (!name) return;" in the helper. :-) Whoops. Yes I definitely meant to add that here. Thanks :) I suggest to add a no_error bool to bind_frag_data_location and always inline it. ok With

Re: [Mesa-dev] [PATCH 11/14] mesa: add bind_frag_data_location() helper

Like you told me in a similar patch, we should keep "if (!name) return;" in the helper. :-) I suggest to add a no_error bool to bind_frag_data_location and always inline it. With that fixed, patch is: Reviewed-by: Samuel Pitoiset On 06/28/2017 08:13 AM, Timothy

[Mesa-dev] [PATCH 11/14] mesa: add bind_frag_data_location() helper

--- src/mesa/main/shader_query.cpp | 30 +++--- 1 file changed, 19 insertions(+), 11 deletions(-) diff --git a/src/mesa/main/shader_query.cpp b/src/mesa/main/shader_query.cpp index 6efbc37..d571846 100644 --- a/src/mesa/main/shader_query.cpp +++