Re: [Mesa-dev] [PATCH 17/20] i965: Preserve CFG when deleting dead control flow.

2014-08-21 Thread Pohjolainen, Topi
On Wed, Aug 20, 2014 at 01:58:24PM -0700, Matt Turner wrote: On Tue, Aug 19, 2014 at 12:36 PM, Pohjolainen, Topi topi.pohjolai...@intel.com wrote: On Tue, Aug 19, 2014 at 12:03:01PM -0700, Matt Turner wrote: By the way, I committed the first 6 patches of the series (the one touching the

Re: [Mesa-dev] [PATCH 17/20] i965: Preserve CFG when deleting dead control flow.

2014-08-20 Thread Matt Turner
On Tue, Aug 19, 2014 at 12:36 PM, Pohjolainen, Topi topi.pohjolai...@intel.com wrote: On Tue, Aug 19, 2014 at 12:03:01PM -0700, Matt Turner wrote: By the way, I committed the first 6 patches of the series (the one touching the generators had started to rot). I think other than 16 and 17, the

Re: [Mesa-dev] [PATCH 17/20] i965: Preserve CFG when deleting dead control flow.

2014-08-19 Thread Pohjolainen, Topi
On Thu, Jul 24, 2014 at 07:54:24PM -0700, Matt Turner wrote: This pass deletes an IF/ELSE/ENDIF or IF/ENDIF sequence, or the ELSE in an ELSE/ENDIF sequence. In the typical case (where IF and ENDIF) aren't the only instructions in their basic blocks, we can simply remove the instructions

Re: [Mesa-dev] [PATCH 17/20] i965: Preserve CFG when deleting dead control flow.

2014-08-19 Thread Matt Turner
On Tue, Aug 19, 2014 at 12:49 AM, Pohjolainen, Topi topi.pohjolai...@intel.com wrote: On Thu, Jul 24, 2014 at 07:54:24PM -0700, Matt Turner wrote: This pass deletes an IF/ELSE/ENDIF or IF/ENDIF sequence, or the ELSE in an ELSE/ENDIF sequence. In the typical case (where IF and ENDIF) aren't

Re: [Mesa-dev] [PATCH 17/20] i965: Preserve CFG when deleting dead control flow.

2014-08-19 Thread Pohjolainen, Topi
On Tue, Aug 19, 2014 at 12:03:01PM -0700, Matt Turner wrote: On Tue, Aug 19, 2014 at 12:49 AM, Pohjolainen, Topi topi.pohjolai...@intel.com wrote: On Thu, Jul 24, 2014 at 07:54:24PM -0700, Matt Turner wrote: This pass deletes an IF/ELSE/ENDIF or IF/ENDIF sequence, or the ELSE in an

Re: [Mesa-dev] [PATCH 17/20] i965: Preserve CFG when deleting dead control flow.

2014-08-19 Thread Matt Turner
On Tue, Aug 19, 2014 at 12:36 PM, Pohjolainen, Topi topi.pohjolai...@intel.com wrote: Oh, so sorry Matt, I somehow forgot to send my r-b, they are just fine. No problem at all. Thanks a ton for reviewing these. I know they've been a lot of work to get through.

[Mesa-dev] [PATCH 17/20] i965: Preserve CFG when deleting dead control flow.

2014-07-24 Thread Matt Turner
This pass deletes an IF/ELSE/ENDIF or IF/ENDIF sequence, or the ELSE in an ELSE/ENDIF sequence. In the typical case (where IF and ENDIF) aren't the only instructions in their basic blocks, we can simply remove the instructions (implicitly deleting the block containing only the ELSE), and attempt