Re: [Mesa-dev] [PATCH 2/2] implement NV_vdpau_interop v3

2013-10-27 Thread Christian König
Am 26.10.2013 19:49, schrieb Paul Berry: On 26 October 2013 07:26, Christian König deathsim...@vodafone.de mailto:deathsim...@vodafone.de wrote: Merged the fixes and pushed the result this morning. Did you by any chance run make check? I'm seeing the following failure: Nope, sorry

Re: [Mesa-dev] [PATCH 2/2] implement NV_vdpau_interop v3

2013-10-26 Thread Christian König
Merged the fixes and pushed the result this morning. Thanks for the help, Christian. Am 26.10.2013 01:25, schrieb Marek Olšák: On Sun, Oct 20, 2013 at 11:57 AM, Christian König deathsim...@vodafone.de wrote: Hi Marek, I've just send out a v6 of the patch, please take a second look. Most

Re: [Mesa-dev] [PATCH 2/2] implement NV_vdpau_interop v3

2013-10-26 Thread Paul Berry
On 26 October 2013 07:26, Christian König deathsim...@vodafone.de wrote: Merged the fixes and pushed the result this morning. Did you by any chance run make check? I'm seeing the following failure: === Mesa 10.0.0-devel:

Re: [Mesa-dev] [PATCH 2/2] implement NV_vdpau_interop v3

2013-10-25 Thread Marek Olšák
On Sun, Oct 20, 2013 at 11:57 AM, Christian König deathsim...@vodafone.de wrote: Hi Marek, I've just send out a v6 of the patch, please take a second look. Most things are fixed now, but there are still a couple of open issues: 3) There should also probably be some checking for

[Mesa-dev] [PATCH 2/2] implement NV_vdpau_interop v3

2013-09-21 Thread Christian König
From: Christian König christian.koe...@amd.com v2: Actually implement interop between the gallium state tracker and the VDPAU backend. v3: Make it also available in non legacy contexts, fix video buffer sharing. Signed-off-by: Christian König christian.koe...@amd.com ---

Re: [Mesa-dev] [PATCH 2/2] implement NV_vdpau_interop v3

2013-09-21 Thread Marek Olšák
1) The Errors section of the spec isn't implemented properly. 2) Passing GL_TEXTURE_RECTANGLE to the new functions should generate an error if ctx-Extensions.NV_texture_rectangle is false. 3) There should also probably be some checking for GL_ARB_texture_non_power_of_two, but the spec doesn't

Re: [Mesa-dev] [PATCH 2/2] implement NV_vdpau_interop v3

2013-09-21 Thread Stephan Raue
Am 21.09.2013 16:56, schrieb Marek Olšák: 8) Do we actually have enough tests, so that we can say this feature works? I have integrated v2 of this patches yesterday in OpenELEC, an embedded XBMC distro and it looks already nice. I will start to create and provide testbuilds for our Users

Re: [Mesa-dev] [PATCH 2/2] implement NV_vdpau_interop v3

2013-09-21 Thread Christian König
Exactly as I though. It's code that I never worked with and I only implemented it so far that XBMC does indeed work, but clearly following the spec is something different. I've committed the rest of the patchset, but I have my doubts that Tim wants me to spend any more time on it, so we

Re: [Mesa-dev] [PATCH 2/2] implement NV_vdpau_interop v3

2013-09-21 Thread Christian König
Am 21.09.2013 17:35, schrieb Stephan Raue: Am 21.09.2013 16:56, schrieb Marek Olšák: 8) Do we actually have enough tests, so that we can say this feature works? I have integrated v2 of this patches yesterday in OpenELEC, an embedded XBMC distro and it looks already nice. I will start to