Re: [Mesa-dev] [PATCH 2/3] mesa/st: add support for ARB_sample_shading

2014-04-01 Thread Marek Olšák
1) Adding functions to cso_context only makes sense for features which need to be disabled or changed for meta ops (e.g. clear_with_quad, glBitmap, glDrawPixels). I don't see you using cso_save_sample_shading, which clearly shows it's useless. Does sample shading need to be set differently for

Re: [Mesa-dev] [PATCH 2/3] mesa/st: add support for ARB_sample_shading

2014-04-01 Thread Ilia Mirkin
On Tue, Apr 1, 2014 at 10:14 AM, Marek Olšák mar...@gmail.com wrote: 1) Adding functions to cso_context only makes sense for features which need to be disabled or changed for meta ops (e.g. clear_with_quad, glBitmap, glDrawPixels). I don't see you using cso_save_sample_shading, which clearly

Re: [Mesa-dev] [PATCH 2/3] mesa/st: add support for ARB_sample_shading

2014-04-01 Thread Marek Olšák
On Tue, Apr 1, 2014 at 4:45 PM, Ilia Mirkin imir...@alum.mit.edu wrote: On Tue, Apr 1, 2014 at 10:14 AM, Marek Olšák mar...@gmail.com wrote: 1) Adding functions to cso_context only makes sense for features which need to be disabled or changed for meta ops (e.g. clear_with_quad, glBitmap,

[Mesa-dev] [PATCH 2/3] mesa/st: add support for ARB_sample_shading

2014-03-30 Thread Ilia Mirkin
--- src/gallium/auxiliary/cso_cache/cso_context.c| 19 src/gallium/auxiliary/cso_cache/cso_context.h| 4 +++ src/gallium/drivers/freedreno/freedreno_screen.c | 1 + src/gallium/drivers/i915/i915_screen.c | 1 + src/gallium/drivers/ilo/ilo_screen.c |