Re: [Mesa-dev] [PATCH 26/28] glsl: lower tessellation varyings packed with component layout qualifier

2016-02-26 Thread Timothy Arceri
On Thu, 2016-02-25 at 18:32 -0800, Kenneth Graunke wrote: > On Tuesday, December 29, 2015 4:00:26 PM PST Timothy Arceri wrote: > > For tessellation shaders we cannot just copy everything to the > > packed > > varyings like we do in other stages as tessellation uses shared > > memory for > >

Re: [Mesa-dev] [PATCH 26/28] glsl: lower tessellation varyings packed with component layout qualifier

2016-02-25 Thread Timothy Arceri
On Thu, 2016-02-25 at 18:32 -0800, Kenneth Graunke wrote: > On Tuesday, December 29, 2015 4:00:26 PM PST Timothy Arceri wrote: > > For tessellation shaders we cannot just copy everything to the > > packed > > varyings like we do in other stages as tessellation uses shared > > memory for > >

Re: [Mesa-dev] [PATCH 26/28] glsl: lower tessellation varyings packed with component layout qualifier

2016-02-25 Thread Kenneth Graunke
On Tuesday, December 29, 2015 4:00:26 PM PST Timothy Arceri wrote: > For tessellation shaders we cannot just copy everything to the packed > varyings like we do in other stages as tessellation uses shared memory for > varyings, therefore it is only safe to copy array elements that the shader >

Re: [Mesa-dev] [PATCH 26/28] glsl: lower tessellation varyings packed with component layout qualifier

2016-02-17 Thread Timothy Arceri
On Wed, 2016-02-17 at 16:10 -0800, Anuj Phogat wrote: > Timothy, I looked at the patch and feel that I'm not the right person > to review > it. I know very little about tessellation. Maybe Ken has some useful > comments. No problem :) Thanks for looking at everything else. I'll see if I can find

Re: [Mesa-dev] [PATCH 26/28] glsl: lower tessellation varyings packed with component layout qualifier

2016-02-17 Thread Anuj Phogat
Timothy, I looked at the patch and feel that I'm not the right person to review it. I know very little about tessellation. Maybe Ken has some useful comments. On Fri, Feb 5, 2016 at 5:12 PM, Timothy Arceri wrote: > Hi Anuj/anyone who feels like reviewing, > > As

Re: [Mesa-dev] [PATCH 26/28] glsl: lower tessellation varyings packed with component layout qualifier

2016-02-05 Thread Timothy Arceri
Hi Anuj/anyone who feels like reviewing, As this is the last remaining patch in the series that I'd like to get addtional feedback on please let me know what I can do to speed things up. I originally assumed that the code comments would help make reviewing easy despite the size of the patch.

Re: [Mesa-dev] [PATCH 26/28] glsl: lower tessellation varyings packed with component layout qualifier

2015-12-29 Thread Timothy Arceri
On Tue, 2015-12-29 at 16:00 +1100, Timothy Arceri wrote: > For tessellation shaders we cannot just copy everything to the packed > varyings like we do in other stages as tessellation uses shared > memory for > varyings, therefore it is only safe to copy array elements that the > shader > actually

[Mesa-dev] [PATCH 26/28] glsl: lower tessellation varyings packed with component layout qualifier

2015-12-28 Thread Timothy Arceri
For tessellation shaders we cannot just copy everything to the packed varyings like we do in other stages as tessellation uses shared memory for varyings, therefore it is only safe to copy array elements that the shader actually uses. This class searches the IR for uses of varyings and then

Re: [Mesa-dev] [PATCH 26/28] glsl: lower tessellation varyings packed with component layout qualifier

2015-12-28 Thread eocallaghan
On 2015-12-29 16:00, Timothy Arceri wrote: For tessellation shaders we cannot just copy everything to the packed varyings like we do in other stages as tessellation uses shared memory for varyings, therefore it is only safe to copy array elements that the shader actually uses. This class