Re: [Mesa-dev] [PATCH 3/3] intel/compiler: properly size attribute wa_flags array for Vulkan

2017-08-10 Thread Iago Toral
On Wed, 2017-08-09 at 16:18 +0100, Lionel Landwerlin wrote: > Acked-by: Lionel Landwerlin > > I can see that it fixes the tests and it makes sense, but I'm failing > to  > see how gl_attrib_wa_flags ends up being set from anv :/ Sorry, I should've explained that.

Re: [Mesa-dev] [PATCH 3/3] intel/compiler: properly size attribute wa_flags array for Vulkan

2017-08-09 Thread Lionel Landwerlin
Acked-by: Lionel Landwerlin I can see that it fixes the tests and it makes sense, but I'm failing to see how gl_attrib_wa_flags ends up being set from anv :/ Thanks a lot! On 21/07/17 09:26, Iago Toral Quiroga wrote: Mesa will map user defined vertex input

Re: [Mesa-dev] [PATCH 3/3] intel/compiler: properly size attribute wa_flags array for Vulkan

2017-08-06 Thread Iago Toral
This patch is still missing a review. Any takers? Iago On Fri, 2017-07-21 at 10:26 +0200, Iago Toral Quiroga wrote: > Mesa will map user defined vertex input attributes to slots > starting at VERT_ATTRIB_GENERIC0 which gives us room for only 16 > slots (up to GL_VERT_ATTRIB_MAX). This sufficient

[Mesa-dev] [PATCH 3/3] intel/compiler: properly size attribute wa_flags array for Vulkan

2017-07-21 Thread Iago Toral Quiroga
Mesa will map user defined vertex input attributes to slots starting at VERT_ATTRIB_GENERIC0 which gives us room for only 16 slots (up to GL_VERT_ATTRIB_MAX). This sufficient for GL, where we expose exactly 16 vertex attributes for user defined inputs, but in Vulkan we can expose up to 28 (which