Re: [Mesa-dev] [PATCH 3/3] nvc0: rework nvc0_compute_validate_program()

2016-02-25 Thread Ilia Mirkin
On Thu, Feb 25, 2016 at 12:42 PM, Samuel Pitoiset wrote: > It would be easy to make the validate functions return a boolean to handle > errors. I will think more about that stuff. But currently, I prefer to > follow the existing design and drop this boolean. This would

Re: [Mesa-dev] [PATCH 3/3] nvc0: rework nvc0_compute_validate_program()

2016-02-25 Thread Samuel Pitoiset
On 02/25/2016 06:44 PM, Ilia Mirkin wrote: On Thu, Feb 25, 2016 at 12:42 PM, Samuel Pitoiset wrote: It would be easy to make the validate functions return a boolean to handle errors. I will think more about that stuff. But currently, I prefer to follow the existing

Re: [Mesa-dev] [PATCH 3/3] nvc0: rework nvc0_compute_validate_program()

2016-02-25 Thread Samuel Pitoiset
On 02/25/2016 06:35 PM, Ilia Mirkin wrote: On Wed, Feb 24, 2016 at 12:44 PM, Samuel Pitoiset wrote: Reduce the amount of duplicated code by re-using nvc0_program_validate(). While we are at it, change the prototype to return void and remove nvc0_compute.h which is

Re: [Mesa-dev] [PATCH 3/3] nvc0: rework nvc0_compute_validate_program()

2016-02-25 Thread Ilia Mirkin
On Wed, Feb 24, 2016 at 12:44 PM, Samuel Pitoiset wrote: > Reduce the amount of duplicated code by re-using > nvc0_program_validate(). While we are at it, change the prototype > to return void and remove nvc0_compute.h which is now useless. > > Signed-off-by: Samuel

Re: [Mesa-dev] [PATCH 3/3] nvc0: rework nvc0_compute_validate_program()

2016-02-24 Thread Pierre Moreau
On 08:44 PM - Feb 24 2016, Samuel Pitoiset wrote: > > > On 02/24/2016 08:30 PM, Pierre Moreau wrote: > >Hi Samuel, > > > >On 06:44 PM - Feb 24 2016, Samuel Pitoiset wrote: > >>Reduce the amount of duplicated code by re-using > >>nvc0_program_validate(). While we are at it, change the prototype >

Re: [Mesa-dev] [PATCH 3/3] nvc0: rework nvc0_compute_validate_program()

2016-02-24 Thread Samuel Pitoiset
On 02/24/2016 08:30 PM, Pierre Moreau wrote: Hi Samuel, On 06:44 PM - Feb 24 2016, Samuel Pitoiset wrote: Reduce the amount of duplicated code by re-using nvc0_program_validate(). While we are at it, change the prototype to return void and remove nvc0_compute.h which is now useless. Why

Re: [Mesa-dev] [PATCH 3/3] nvc0: rework nvc0_compute_validate_program()

2016-02-24 Thread Pierre Moreau
Hi Samuel, On 06:44 PM - Feb 24 2016, Samuel Pitoiset wrote: > Reduce the amount of duplicated code by re-using > nvc0_program_validate(). While we are at it, change the prototype > to return void and remove nvc0_compute.h which is now useless. Why don't you want to know whether the validation

[Mesa-dev] [PATCH 3/3] nvc0: rework nvc0_compute_validate_program()

2016-02-24 Thread Samuel Pitoiset
Reduce the amount of duplicated code by re-using nvc0_program_validate(). While we are at it, change the prototype to return void and remove nvc0_compute.h which is now useless. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/Makefile.sources | 1