Re: [Mesa-dev] [PATCH 3/3] st/mesa: implement ARB_copy_image

2015-11-03 Thread Marek Olšák
On Wed, Oct 28, 2015 at 5:25 PM, Ilia Mirkin wrote: > On Sun, Oct 25, 2015 at 1:25 PM, Marek Olšák wrote: >> +static void >> +st_CopyImageSubData(struct gl_context *ctx, >> +struct gl_texture_image *src_image, >> +

Re: [Mesa-dev] [PATCH 3/3] st/mesa: implement ARB_copy_image

2015-10-28 Thread Ilia Mirkin
On Sun, Oct 25, 2015 at 1:25 PM, Marek Olšák wrote: > +static void > +st_CopyImageSubData(struct gl_context *ctx, > +struct gl_texture_image *src_image, > +struct gl_renderbuffer *src_renderbuffer, > +int src_x, int

Re: [Mesa-dev] [PATCH 3/3] st/mesa: implement ARB_copy_image

2015-10-27 Thread Nicolai Hähnle
On 25.10.2015 18:25, Marek Olšák wrote: +/** + * Handle complex format conversions using 2 blits with a temporary texture + * in between, e.g. blitting from B10G10R10A2 to G16R16. + * + * This example is implemented this way: + * 1) First, blit from B10G10R10A2 to R10G10B10A2, which is

Re: [Mesa-dev] [PATCH 3/3] st/mesa: implement ARB_copy_image

2015-10-27 Thread Marek Olšák
On Tue, Oct 27, 2015 at 4:26 AM, Ilia Mirkin wrote: >> + >> +static void >> +copy_image(struct pipe_context *pipe, >> + struct pipe_resource *dst, >> + unsigned dst_level, >> + unsigned dstx, unsigned dsty, unsigned dstz, >> + struct

Re: [Mesa-dev] [PATCH 3/3] st/mesa: implement ARB_copy_image

2015-10-27 Thread Michel Dänzer
On 26.10.2015 02:25, Marek Olšák wrote: > > +/** > + * Handle complex format conversions using 2 blits with a temporary texture > + * in between, e.g. blitting from B10G10R10A2 to G16R16. > + * > + * This example is implemented this way: > + * 1) First, blit from B10G10R10A2 to R10G10B10A2, which

Re: [Mesa-dev] [PATCH 3/3] st/mesa: implement ARB_copy_image

2015-10-27 Thread Marek Olšák
On Tue, Oct 27, 2015 at 10:33 AM, Michel Dänzer wrote: > On 26.10.2015 02:25, Marek Olšák wrote: >> >> +/** >> + * Handle complex format conversions using 2 blits with a temporary texture >> + * in between, e.g. blitting from B10G10R10A2 to G16R16. >> + * >> + * This example

Re: [Mesa-dev] [PATCH 3/3] st/mesa: implement ARB_copy_image

2015-10-26 Thread Ilia Mirkin
On Sun, Oct 25, 2015 at 1:25 PM, Marek Olšák wrote: > From: Marek Olšák > > I wonder if the craziness was worth it. > --- > src/mesa/Makefile.sources| 2 + > src/mesa/state_tracker/st_cb_copyimage.c | 609 >

Re: [Mesa-dev] [PATCH 3/3] st/mesa: implement ARB_copy_image

2015-10-26 Thread Brian Paul
Looks good to me. Yeah, it is kind of crazy. I think softpipe/llvmpipe just need one of my previous patches, plus minor updates. I'll take care of that. Just one minor nit below. Oh, and you could probably mention support for GL_ARB_copy_image in the release notes file and GL3.txt.

[Mesa-dev] [PATCH 3/3] st/mesa: implement ARB_copy_image

2015-10-25 Thread Marek Olšák
From: Marek Olšák I wonder if the craziness was worth it. --- src/mesa/Makefile.sources| 2 + src/mesa/state_tracker/st_cb_copyimage.c | 609 +++ src/mesa/state_tracker/st_cb_copyimage.h | 33 ++