Re: [Mesa-dev] [PATCH 3/4] ac/nir: fix 64-bit shifts

I didn't enable the Int64 capability for radv until the next patch in this series, so the problem this fixes was never exposed to users at all. I just ran into it when enabling VK_EXT_shader_ballot -- the extension doesn't require it, but the only way to generate SPIR-V using it with glslang is

Re: [Mesa-dev] [PATCH 3/4] ac/nir: fix 64-bit shifts

Connor, it looks like we could want this patch in 17.1 (?) On Fri, 2017-06-30 at 19:56 -0700, Connor Abbott wrote: > From: Connor Abbott > > NIR always makes the shift amount 32 bits, but LLVM asserts if the two > sources aren't the same type. Zero-extend the shift amount

Re: [Mesa-dev] [PATCH 3/4] ac/nir: fix 64-bit shifts

Connor, it looks like we could want this patch in 17.1 (?) On Fri, 2017-06-30 at 19:56 -0700, Connor Abbott wrote: > From: Connor Abbott > > NIR always makes the shift amount 32 bits, but LLVM asserts if the two > sources aren't the same type. Zero-extend the shift amount

[Mesa-dev] [PATCH 3/4] ac/nir: fix 64-bit shifts

From: Connor Abbott NIR always makes the shift amount 32 bits, but LLVM asserts if the two sources aren't the same type. Zero-extend the shift amount to make LLVM happy. Signed-off-by: Connor Abbott --- src/amd/common/ac_nir_to_llvm.c | 15