Re: [Mesa-dev] [PATCH 4/4] nir/spirv: Make gl_PrimitiveId a system value

2016-11-11 Thread Jason Ekstrand
On Fri, Nov 11, 2016 at 1:39 PM, Ilia Mirkin wrote: > On Fri, Nov 11, 2016 at 10:23 AM, Jason Ekstrand > wrote: > > On Nov 11, 2016 6:16 AM, "Ilia Mirkin" wrote: > >> > >> I haven't checked spirv for the specific naming, but

Re: [Mesa-dev] [PATCH 4/4] nir/spirv: Make gl_PrimitiveId a system value

2016-11-11 Thread Ilia Mirkin
On Fri, Nov 11, 2016 at 10:23 AM, Jason Ekstrand wrote: > On Nov 11, 2016 6:16 AM, "Ilia Mirkin" wrote: >> >> I haven't checked spirv for the specific naming, but note that prim ID can >> be an output in gs. > > You're right. I'm not 100% site how we

Re: [Mesa-dev] [PATCH 4/4] nir/spirv: Make gl_PrimitiveId a system value

2016-11-11 Thread Jason Ekstrand
On Nov 11, 2016 6:16 AM, "Ilia Mirkin" wrote: > > I haven't checked spirv for the specific naming, but note that prim ID can be an output in gs. You're right. I'm not 100% site how we handle that today. We probably just pass it through as a varying. It looks like the

Re: [Mesa-dev] [PATCH 4/4] nir/spirv: Make gl_PrimitiveId a system value

2016-11-11 Thread Ilia Mirkin
I haven't checked spirv for the specific naming, but note that prim ID can be an output in gs. On Nov 11, 2016 1:34 AM, "Jason Ekstrand" wrote: > Before, we were treating it as an output which is just completely bogus. > We could go for an input but a system value makes

[Mesa-dev] [PATCH 4/4] nir/spirv: Make gl_PrimitiveId a system value

2016-11-10 Thread Jason Ekstrand
Before, we were treating it as an output which is just completely bogus. We could go for an input but a system value makes more sense. Cc: "13.0" --- src/compiler/spirv/vtn_variables.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git