Re: [Mesa-dev] [PATCH 4/9] mesa: add helper convenience functions for fetching geometry of gl_framebuffer

2015-05-06 Thread Rogovin, Kevin
: Wednesday, May 06, 2015 10:28 AM To: 'Ian Romanick'; mesa-...@freedesktop.org Subject: RE: [Mesa-dev] [PATCH 4/9] mesa: add helper convenience functions for fetching geometry of gl_framebuffer I'm waffling about this a bit. I'm concerned that people will use buffer-Width when they should use

Re: [Mesa-dev] [PATCH 4/9] mesa: add helper convenience functions for fetching geometry of gl_framebuffer

2015-05-06 Thread Ian Romanick
On 04/29/2015 01:56 AM, kevin.rogo...@intel.com wrote: From: Kevin Rogovin kevin.rogo...@intel.com Add convenience helper functions for fetching geometry of gl_framebuffer that return the geometry of the gl_framebuffer instead of the geometry of the buffers of the gl_framebuffer when then

Re: [Mesa-dev] [PATCH 4/9] mesa: add helper convenience functions for fetching geometry of gl_framebuffer

2015-05-06 Thread Rogovin, Kevin
I'm waffling about this a bit. I'm concerned that people will use buffer-Width when they should use the accessor. I don't see any changes to core Mesa code to use the accessor, so I'm a little concerned that some subtle, incorrect behavior is introduced... but there may well not be. A

Re: [Mesa-dev] [PATCH 4/9] mesa: add helper convenience functions for fetching geometry of gl_framebuffer

2015-05-06 Thread Rogovin, Kevin
: Wednesday, May 06, 2015 1:00 PM To: 'Ian Romanick'; 'mesa-...@freedesktop.org' Subject: RE: [Mesa-dev] [PATCH 4/9] mesa: add helper convenience functions for fetching geometry of gl_framebuffer One more question: for patch 2 of the series, there was the request to change the type

[Mesa-dev] [PATCH 4/9] mesa: add helper convenience functions for fetching geometry of gl_framebuffer

2015-04-29 Thread kevin . rogovin
From: Kevin Rogovin kevin.rogo...@intel.com Add convenience helper functions for fetching geometry of gl_framebuffer that return the geometry of the gl_framebuffer instead of the geometry of the buffers of the gl_framebuffer when then the gl_framebuffer has no attachments. ---