Re: [Mesa-dev] [PATCH 7/9] i965: ensure execution of fragment shader when fragment shader has atomic buffer access

2015-05-06 Thread Ian Romanick
On 04/29/2015 01:56 AM, kevin.rogo...@intel.com wrote: From: Kevin Rogovin kevin.rogo...@intel.com If the fragment shader has atomic buffer access, the shader must execute even if the current draw buffer has no attachments. --- src/mesa/drivers/dri/i965/gen7_wm_state.c | 7 +++

Re: [Mesa-dev] [PATCH 7/9] i965: ensure execution of fragment shader when fragment shader has atomic buffer access

2015-05-06 Thread Rogovin, Kevin
Hi, I think this check should be put in a utility function up in core Mesa somewhere. It's open-coded twice in this patch, and the check will change when GL_ARB_image_load_store lands. Would a check of the form: inline bool _mesa_has_atomic_ops(struct gl_context *ctx) { return ctx-

[Mesa-dev] [PATCH 7/9] i965: ensure execution of fragment shader when fragment shader has atomic buffer access

2015-04-29 Thread kevin . rogovin
From: Kevin Rogovin kevin.rogo...@intel.com If the fragment shader has atomic buffer access, the shader must execute even if the current draw buffer has no attachments. --- src/mesa/drivers/dri/i965/gen7_wm_state.c | 7 +++ src/mesa/drivers/dri/i965/gen8_ps_state.c | 4 2 files