Re: [Mesa-dev] [PATCH 8/8] i965: Enable EXT_shader_samples_identical

2015-11-19 Thread Jason Ekstrand
On Wed, Nov 18, 2015 at 9:29 PM, Jason Ekstrand wrote: > > On Nov 18, 2015 5:02 PM, "Jason Ekstrand" wrote: >> >> On Wed, Nov 18, 2015 at 4:06 PM, Kenneth Graunke >> wrote: >> > On Wednesday, November 18, 2015 03:46:54 PM Ian

Re: [Mesa-dev] [PATCH 8/8] i965: Enable EXT_shader_samples_identical

2015-11-19 Thread Neil Roberts
Jason Ekstrand writes: > Something else that came out of that conversation is that, for 2x > MSAA, we may get bogus data in all but the bottom 4 bits. In other > words, just blindly checking for zero is probably a bad idea. It'll > work because the extension spec lets us

Re: [Mesa-dev] [PATCH 8/8] i965: Enable EXT_shader_samples_identical

2015-11-18 Thread Jason Ekstrand
On Wed, Nov 18, 2015 at 5:31 PM, Ian Romanick wrote: > On 11/18/2015 05:02 PM, Jason Ekstrand wrote: >> On Wed, Nov 18, 2015 at 4:06 PM, Kenneth Graunke >> wrote: >>> On Wednesday, November 18, 2015 03:46:54 PM Ian Romanick wrote: From: Ian

Re: [Mesa-dev] [PATCH 8/8] i965: Enable EXT_shader_samples_identical

2015-11-18 Thread Ian Romanick
On 11/18/2015 04:06 PM, Kenneth Graunke wrote: > On Wednesday, November 18, 2015 03:46:54 PM Ian Romanick wrote: >> From: Ian Romanick >> >> Signed-off-by: Ian Romanick >> --- >> src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 1 + >>

Re: [Mesa-dev] [PATCH 8/8] i965: Enable EXT_shader_samples_identical

2015-11-18 Thread Ian Romanick
On 11/18/2015 05:02 PM, Jason Ekstrand wrote: > On Wed, Nov 18, 2015 at 4:06 PM, Kenneth Graunke > wrote: >> On Wednesday, November 18, 2015 03:46:54 PM Ian Romanick wrote: >>> From: Ian Romanick >>> >>> Signed-off-by: Ian Romanick

Re: [Mesa-dev] [PATCH 8/8] i965: Enable EXT_shader_samples_identical

2015-11-18 Thread Jason Ekstrand
On Wed, Nov 18, 2015 at 4:06 PM, Kenneth Graunke wrote: > On Wednesday, November 18, 2015 03:46:54 PM Ian Romanick wrote: >> From: Ian Romanick >> >> Signed-off-by: Ian Romanick >> --- >>

Re: [Mesa-dev] [PATCH 8/8] i965: Enable EXT_shader_samples_identical

2015-11-18 Thread Jason Ekstrand
On Wed, Nov 18, 2015 at 5:23 PM, Ian Romanick wrote: > On 11/18/2015 04:06 PM, Kenneth Graunke wrote: >> On Wednesday, November 18, 2015 03:46:54 PM Ian Romanick wrote: >>> From: Ian Romanick >>> >>> Signed-off-by: Ian Romanick

[Mesa-dev] [PATCH 8/8] i965: Enable EXT_shader_samples_identical

2015-11-18 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 1 + src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 16 src/mesa/drivers/dri/i965/brw_vec4_nir.cpp | 1 +

Re: [Mesa-dev] [PATCH 8/8] i965: Enable EXT_shader_samples_identical

2015-11-18 Thread Kenneth Graunke
On Wednesday, November 18, 2015 03:46:54 PM Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > --- > src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 1 + > src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 16

Re: [Mesa-dev] [PATCH 8/8] i965: Enable EXT_shader_samples_identical

2015-11-18 Thread Jason Ekstrand
On Nov 18, 2015 5:02 PM, "Jason Ekstrand" wrote: > > On Wed, Nov 18, 2015 at 4:06 PM, Kenneth Graunke wrote: > > On Wednesday, November 18, 2015 03:46:54 PM Ian Romanick wrote: > >> From: Ian Romanick > >> > >>