Re: [Mesa-dev] [PATCH 8/8 v2] i965: Enable EXT_shader_samples_identical

2015-11-21 Thread Kenneth Graunke
On Thursday, November 19, 2015 11:13:15 PM Neil Roberts wrote: > Ian Romanick writes: > > > Am I correct that nothing special is needed in the vec4 backend? It > > seems like mcs should know the register size, and the CMP with 0 > > should just do the right thing. > > I

Re: [Mesa-dev] [PATCH 8/8 v2] i965: Enable EXT_shader_samples_identical

2015-11-19 Thread Ian Romanick
On 11/19/2015 09:34 AM, Neil Roberts wrote: > Jason Ekstrand writes: > >> On Nov 18, 2015 6:38 PM, "Ian Romanick" wrote: >>> >>> From: Ian Romanick >>> >>> v2: Handle immediate value for MCS smarter. Rebase on changes to

Re: [Mesa-dev] [PATCH 8/8 v2] i965: Enable EXT_shader_samples_identical

2015-11-19 Thread Neil Roberts
Ian Romanick writes: > Am I correct that nothing special is needed in the vec4 backend? It > seems like mcs should know the register size, and the CMP with 0 > should just do the right thing. I think you probably will have to do something for the vec4 backend. Currently it

Re: [Mesa-dev] [PATCH 8/8 v2] i965: Enable EXT_shader_samples_identical

2015-11-19 Thread Ian Romanick
On 11/19/2015 02:13 PM, Neil Roberts wrote: > Ian Romanick writes: > >> Am I correct that nothing special is needed in the vec4 backend? It >> seems like mcs should know the register size, and the CMP with 0 >> should just do the right thing. > > I think you probably will

Re: [Mesa-dev] [PATCH 8/8 v2] i965: Enable EXT_shader_samples_identical

2015-11-19 Thread Neil Roberts
Jason Ekstrand writes: > On Nov 18, 2015 6:38 PM, "Ian Romanick" wrote: >> >> From: Ian Romanick >> >> v2: Handle immediate value for MCS smarter. Rebase on changes to >> nir_texop_sampels_identical (missing second

[Mesa-dev] [PATCH 8/8 v2] i965: Enable EXT_shader_samples_identical

2015-11-18 Thread Ian Romanick
From: Ian Romanick v2: Handle immediate value for MCS smarter. Rebase on changes to nir_texop_sampels_identical (missing second parameter). Suggested by Jason. This still doesn't handle the 16x MSAA case. Signed-off-by: Ian Romanick ---

Re: [Mesa-dev] [PATCH 8/8 v2] i965: Enable EXT_shader_samples_identical

2015-11-18 Thread Jason Ekstrand
On Nov 18, 2015 6:38 PM, "Ian Romanick" wrote: > > From: Ian Romanick > > v2: Handle immediate value for MCS smarter. Rebase on changes to > nir_texop_sampels_identical (missing second parameter). Suggested by > Jason. This still doesn't handle