Re: [Mesa-dev] [PATCH 9/9] mark GL_ARB_framebuffer_no_attachments as done for i965

2015-05-06 Thread Ian Romanick
With Petri and Ilia's comments addressed, this patch is Reviewed-by: Ian Romanick ian.d.roman...@intel.com On 04/29/2015 01:56 AM, kevin.rogo...@intel.com wrote: From: Kevin Rogovin kevin.rogo...@intel.com Mark GL_ARB_framebuffer_no_attachments as done for i965. --- docs/GL3.txt

Re: [Mesa-dev] [PATCH 9/9] mark GL_ARB_framebuffer_no_attachments as done for i965

2015-04-30 Thread Tapani Pälli
On 04/29/2015 11:57 PM, Rogovin, Kevin wrote: Hi, I'd just go read the ES 3.1 spec and see if there are any differences in this area. I checked the spec, and it appears to me to have the same behavior as GL_ARB_framebuffer_no_attachments. I've just gone through it and can't spot any

[Mesa-dev] [PATCH 9/9] mark GL_ARB_framebuffer_no_attachments as done for i965

2015-04-29 Thread kevin . rogovin
From: Kevin Rogovin kevin.rogo...@intel.com Mark GL_ARB_framebuffer_no_attachments as done for i965. --- docs/GL3.txt | 2 +- docs/relnotes/10.6.0.html | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index 172fd3c..cf3b5a2 100644 ---

Re: [Mesa-dev] [PATCH 9/9] mark GL_ARB_framebuffer_no_attachments as done for i965

2015-04-29 Thread Petri Latvala
On 04/29/2015 11:56 AM, kevin.rogo...@intel.com wrote: From: Kevin Rogovin kevin.rogo...@intel.com Mark GL_ARB_framebuffer_no_attachments as done for i965. --- docs/GL3.txt | 2 +- docs/relnotes/10.6.0.html | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH 9/9] mark GL_ARB_framebuffer_no_attachments as done for i965

2015-04-29 Thread Matt Turner
On Wed, Apr 29, 2015 at 6:36 AM, Rogovin, Kevin kevin.rogo...@intel.com wrote: At the bottom is another block with GLES 3.1 requirements, which also contains GL_ARB_f_n_a. At first, I said “Oh futz, I did not mark that one”. Then I did some thinking. Before expressing my thoughts I want

Re: [Mesa-dev] [PATCH 9/9] mark GL_ARB_framebuffer_no_attachments as done for i965

2015-04-29 Thread Rogovin, Kevin
When you rebase this, I'd appreciate it if you could insert it into the list in alphabetical order. (You based this on a commit where a bunch of the later additions were already not inserted alphabetically, but I've recently fixed that up.) Sure, no worries. Given that I am just changing the

Re: [Mesa-dev] [PATCH 9/9] mark GL_ARB_framebuffer_no_attachments as done for i965

2015-04-29 Thread Ilia Mirkin
On Wed, Apr 29, 2015 at 2:35 PM, Rogovin, Kevin kevin.rogo...@intel.com wrote: When you rebase this, I'd appreciate it if you could insert it into the list in alphabetical order. (You based this on a commit where a bunch of the later additions were already not inserted alphabetically, but I've

Re: [Mesa-dev] [PATCH 9/9] mark GL_ARB_framebuffer_no_attachments as done for i965

2015-04-29 Thread Rogovin, Kevin
Hi, I'd just go read the ES 3.1 spec and see if there are any differences in this area. I checked the spec, and it appears to me to have the same behavior as GL_ARB_framebuffer_no_attachments. Also, please fix your mail client to stop its weird line wrapping (and the other half of the

Re: [Mesa-dev] [PATCH 9/9] mark GL_ARB_framebuffer_no_attachments as done for i965

2015-04-29 Thread Rogovin, Kevin
At the bottom is another block with GLES 3.1 requirements, which also contains GL_ARB_f_n_a. At first, I said Oh futz, I did not mark that one. Then I did some thinking. Before expressing my thoughts I want to emphasize that I really do not know what is the best answer, or potentially even

Re: [Mesa-dev] [PATCH 9/9] mark GL_ARB_framebuffer_no_attachments as done for i965

2015-04-29 Thread Ilia Mirkin
On Wed, Apr 29, 2015 at 4:56 AM, kevin.rogo...@intel.com wrote: From: Kevin Rogovin kevin.rogo...@intel.com Mark GL_ARB_framebuffer_no_attachments as done for i965. --- docs/GL3.txt | 2 +- docs/relnotes/10.6.0.html | 1 + 2 files changed, 2 insertions(+), 1 deletion(-)