Re: [Mesa-dev] [PATCH V4 2/6] glsl: assign hidden uniforms their slot id earlier

2015-10-14 Thread Timothy Arceri
On Tue, 2015-10-13 at 12:20 +0200, Marek Olšák wrote: > On Tue, Oct 13, 2015 at 10:13 AM, Timothy Arceri < > t_arc...@yahoo.com.au> wrote: > > On Mon, 2015-10-12 at 01:06 +0200, Marek Olšák wrote: > > > On Sun, Oct 11, 2015 at 9:20 AM, Timothy Arceri < > > > t_arc...@yahoo.com.au> wrote: > > > >

Re: [Mesa-dev] [PATCH V4 2/6] glsl: assign hidden uniforms their slot id earlier

2015-10-13 Thread Timothy Arceri
On Mon, 2015-10-12 at 01:06 +0200, Marek Olšák wrote: > On Sun, Oct 11, 2015 at 9:20 AM, Timothy Arceri < > t_arc...@yahoo.com.au> wrote: > > On Sat, 2015-10-10 at 18:06 +0200, Marek Olšák wrote: > > > Hi Timothy, > > > > > > One of these 3 commits breaks compilation for Talos shaders with > > >

Re: [Mesa-dev] [PATCH V4 2/6] glsl: assign hidden uniforms their slot id earlier

2015-10-13 Thread Timothy Arceri
On Mon, 2015-10-12 at 01:06 +0200, Marek Olšák wrote: > On Sun, Oct 11, 2015 at 9:20 AM, Timothy Arceri < > t_arc...@yahoo.com.au> wrote: > > On Sat, 2015-10-10 at 18:06 +0200, Marek Olšák wrote: > > > Hi Timothy, > > > > > > One of these 3 commits breaks compilation for Talos shaders with > > >

Re: [Mesa-dev] [PATCH V4 2/6] glsl: assign hidden uniforms their slot id earlier

2015-10-13 Thread Michel Dänzer
On 11.10.2015 16:20, Timothy Arceri wrote: > On Sat, 2015-10-10 at 18:06 +0200, Marek Olšák wrote: >> Hi Timothy, >> >> One of these 3 commits breaks compilation for Talos shaders with >> gallium. My piglit patch "glsl-1.30/sampler-bug: ..." contains a >> minimal test case. I can't say which

Re: [Mesa-dev] [PATCH V4 2/6] glsl: assign hidden uniforms their slot id earlier

2015-10-13 Thread Marek Olšák
On Tue, Oct 13, 2015 at 10:13 AM, Timothy Arceri wrote: > On Mon, 2015-10-12 at 01:06 +0200, Marek Olšák wrote: >> On Sun, Oct 11, 2015 at 9:20 AM, Timothy Arceri < >> t_arc...@yahoo.com.au> wrote: >> > On Sat, 2015-10-10 at 18:06 +0200, Marek Olšák wrote: >> > > Hi

Re: [Mesa-dev] [PATCH V4 2/6] glsl: assign hidden uniforms their slot id earlier

2015-10-11 Thread Timothy Arceri
On Sat, 2015-10-10 at 18:06 +0200, Marek Olšák wrote: > Hi Timothy, > > One of these 3 commits breaks compilation for Talos shaders with > gallium. My piglit patch "glsl-1.30/sampler-bug: ..." contains a > minimal test case. I can't say which commit, because Mesa fails to > build between them. >

Re: [Mesa-dev] [PATCH V4 2/6] glsl: assign hidden uniforms their slot id earlier

2015-10-11 Thread Marek Olšák
On Sun, Oct 11, 2015 at 9:20 AM, Timothy Arceri wrote: > On Sat, 2015-10-10 at 18:06 +0200, Marek Olšák wrote: >> Hi Timothy, >> >> One of these 3 commits breaks compilation for Talos shaders with >> gallium. My piglit patch "glsl-1.30/sampler-bug: ..." contains a >>

Re: [Mesa-dev] [PATCH V4 2/6] glsl: assign hidden uniforms their slot id earlier

2015-10-10 Thread Marek Olšák
Hi Timothy, One of these 3 commits breaks compilation for Talos shaders with gallium. My piglit patch "glsl-1.30/sampler-bug: ..." contains a minimal test case. I can't say which commit, because Mesa fails to build between them. It has something to do with uniforms, structures, and samplers.

[Mesa-dev] [PATCH V4 2/6] glsl: assign hidden uniforms their slot id earlier

2015-09-15 Thread Timothy Arceri
This is required so that the next patch can safely assign the slot id to the var. The ids are now assigned in the order we want before allocating storage so there is no need to sort the storage array and move things around. V2: rename variable to make code easier to follow as suggested by Jason