Re: [Mesa-dev] [PATCH mesa] mesa/format_info: use designated initialiser list

2017-06-20 Thread Eric Engestrom
On Tuesday, 2017-06-20 09:47:30 -0700, Ian Romanick wrote: > On 06/20/2017 07:24 AM, Brian Paul wrote: > > On 06/19/2017 03:39 PM, Ian Romanick wrote: > >> On 06/19/2017 04:01 AM, Eric Engestrom wrote: > >>> Also, make that table const, since no-one is supposed to modify it > >>> anyway. > >> > >>

Re: [Mesa-dev] [PATCH mesa] mesa/format_info: use designated initialiser list

2017-06-20 Thread Ian Romanick
On 06/20/2017 07:24 AM, Brian Paul wrote: > On 06/19/2017 03:39 PM, Ian Romanick wrote: >> On 06/19/2017 04:01 AM, Eric Engestrom wrote: >>> Also, make that table const, since no-one is supposed to modify it >>> anyway. >> >> I certainly like this, but I'm not sure we can use designated >>

Re: [Mesa-dev] [PATCH mesa] mesa/format_info: use designated initialiser list

2017-06-20 Thread Eric Engestrom
On Tuesday, 2017-06-20 08:24:42 -0600, Brian Paul wrote: > On 06/19/2017 03:39 PM, Ian Romanick wrote: > > On 06/19/2017 04:01 AM, Eric Engestrom wrote: > > > Also, make that table const, since no-one is supposed to modify it anyway. > > > > I certainly like this, but I'm not sure we can use

Re: [Mesa-dev] [PATCH mesa] mesa/format_info: use designated initialiser list

2017-06-20 Thread Brian Paul
On 06/19/2017 03:39 PM, Ian Romanick wrote: On 06/19/2017 04:01 AM, Eric Engestrom wrote: Also, make that table const, since no-one is supposed to modify it anyway. I certainly like this, but I'm not sure we can use designated initializers in common Mesa code due to MSVC. Brian? They

Re: [Mesa-dev] [PATCH mesa] mesa/format_info: use designated initialiser list

2017-06-20 Thread Emil Velikov
On 19 June 2017 at 22:39, Ian Romanick wrote: > On 06/19/2017 04:01 AM, Eric Engestrom wrote: >> Also, make that table const, since no-one is supposed to modify it anyway. > > I certainly like this, but I'm not sure we can use designated > initializers in common Mesa code

Re: [Mesa-dev] [PATCH mesa] mesa/format_info: use designated initialiser list

2017-06-19 Thread Ian Romanick
On 06/19/2017 04:01 AM, Eric Engestrom wrote: > Also, make that table const, since no-one is supposed to modify it anyway. I certainly like this, but I'm not sure we can use designated initializers in common Mesa code due to MSVC. Brian? > Signed-off-by: Eric Engestrom

[Mesa-dev] [PATCH mesa] mesa/format_info: use designated initialiser list

2017-06-19 Thread Eric Engestrom
Also, make that table const, since no-one is supposed to modify it anyway. Signed-off-by: Eric Engestrom --- I was grepping for a field to see where it was being set, and I couldn't find it because it was using positional struct initialisation. Ended up finding it,