On 21/11/2018 21:17, Ian Romanick wrote:
On 11/21/2018 12:16 PM, Jose Fonseca wrote:
util: use standard name for strncat()
util: use standard name for strncmp()
util: use standard name for strcmp()
util: use standard name for strchr()
util: use standard name for sprintf()
e check all other util_snprintf . It's possible that
> the mere fact we statically link CRT is sufficient to protect us from
> that (since it ends up being like a completely different CRT instant
> from the application), but I'm not 100% sure.
>
>
> Jose
>
>
> ----------------
> *From:* Ian Ro
day, November 21, 2018 8:16:35 PM
To: Ian Romanick; Eric Engestrom; mesa-dev@lists.freedesktop.org
Cc: Brian Paul; Roland Scheidegger; Neha Bhende; Charmaine Lee
Subject: Re: [Mesa-dev] [PATCH mesa 00/13] Make standard function available on
non-standard platforms
> util: use standard name for s
stant from the application), but I'm not 100% sure.
Jose
From: Ian Romanick
Sent: Wednesday, November 21, 2018 18:47
To: Eric Engestrom; mesa-dev@lists.freedesktop.org
Cc: Jose Fonseca
Subject: Re: [Mesa-dev] [PATCH mesa 00/13] Make standard function available on
n
On 11/20/2018 05:11 AM, Eric Engestrom wrote:
> ... instead of making standard platforms use non-standard functions.
I haven't looked at the specific patches, so this comment may not apply.
When we first headed down the path of adding a billion wrapper
functions, I campaigned pretty strongly to
On 2018/11/20, Eric Engestrom wrote:
> ... instead of making standard platforms use non-standard functions.
>
> This also reduces the likelihood of someone forgetting to use the
> non-standard function, and reduces the fix to a simple #include.
>
Yes, please.
One could take thing a step
Eric Engestrom writes:
> ... instead of making standard platforms use non-standard functions.
>
> This also reduces the likelihood of someone forgetting to use the
> non-standard function, and reduces the fix to a simple #include.
Thank you so much for doing this!
Reviewed-by: Eric Anholt
... instead of making standard platforms use non-standard functions.
This also reduces the likelihood of someone forgetting to use the
non-standard function, and reduces the fix to a simple #include.
Changes generated using this shell function for each function name:
fix() {
files=$(ag -lw
