Re: [Mesa-dev] [PATCH v2] docs: Document GitLab merge request process (email alternative)

2018-12-14 Thread Gert Wollny
Am Freitag, den 14.12.2018, 12:38 +0100 schrieb Samuel Pitoiset: > > On 12/13/18 9:27 PM, Gert Wollny wrote: > > IMHO allowing MRs is a good thing, so > >Acked-by: Gert Wollny > > > > Allowing MRs isn't a bad thing. The main problem IMHO is that now we > have to look at both emails and

Re: [Mesa-dev] [PATCH v2] docs: Document GitLab merge request process (email alternative)

2018-12-14 Thread Samuel Pitoiset
On 12/13/18 9:27 PM, Gert Wollny wrote: IMHO allowing MRs is a good thing, so Acked-by: Gert Wollny Allowing MRs isn't a bad thing. The main problem IMHO is that now we have to look at both emails and MRs, and I think we are probably going to miss interesting/important changes. I've

Re: [Mesa-dev] [PATCH v2] docs: Document GitLab merge request process (email alternative)

2018-12-14 Thread Erik Faye-Lund
On Thu, 2018-12-13 at 21:27 +0100, Gert Wollny wrote: > IMHO allowing MRs is a good thing, so > Acked-by: Gert Wollny > > I've added a little remark below. > > Best, > Gert > > Am Mittwoch, den 05.12.2018, 15:32 -0800 schrieb Jordan Justen: > > +You should periodically check to see

Re: [Mesa-dev] [PATCH v2] docs: Document GitLab merge request process (email alternative)

2018-12-14 Thread Erik Faye-Lund
On Thu, 2018-12-13 at 18:07 +0100, Axel Davy wrote: > On 13/12/2018 17:57, Mathias Fröhlich wrote: > > Hi, > > Initially it seemed to me that I am about the only one sticking > > with mailing lists. > > And I personally feel like a too small contributor to really try to > > influence your > >

Re: [Mesa-dev] [PATCH v2] docs: Document GitLab merge request process (email alternative)

2018-12-13 Thread Gert Wollny
IMHO allowing MRs is a good thing, so Acked-by: Gert Wollny I've added a little remark below. Best, Gert Am Mittwoch, den 05.12.2018, 15:32 -0800 schrieb Jordan Justen: > This documents a process for using GitLab Merge Requests as an second > way to submit code changes for Mesa. Only

Re: [Mesa-dev] [PATCH v2] docs: Document GitLab merge request process (email alternative)

2018-12-13 Thread Eric Anholt
Jason Ekstrand writes: > On Thu, Dec 13, 2018 at 11:07 AM Axel Davy wrote: > >> On 13/12/2018 17:57, Mathias Fröhlich wrote: >> > Hi, >> > Initially it seemed to me that I am about the only one sticking with >> mailing lists. >> > And I personally feel like a too small contributor to really try

Re: [Mesa-dev] [PATCH v2] docs: Document GitLab merge request process (email alternative)

2018-12-13 Thread Dylan Baker
Quoting Alex Deucher (2018-12-13 07:52:04) > On Wed, Dec 12, 2018 at 3:42 AM Samuel Pitoiset > wrote: > > > > Personally, I will continue to use the list, at least for a simplicity > > point of view. I'm not sure if using a new tool will improve quality and > > code review process. > > > >

Re: [Mesa-dev] [PATCH v2] docs: Document GitLab merge request process (email alternative)

2018-12-13 Thread Jason Ekstrand
On Thu, Dec 13, 2018 at 11:07 AM Axel Davy wrote: > On 13/12/2018 17:57, Mathias Fröhlich wrote: > > Hi, > > Initially it seemed to me that I am about the only one sticking with > mailing lists. > > And I personally feel like a too small contributor to really try to > influence your > >

Re: [Mesa-dev] [PATCH v2] docs: Document GitLab merge request process (email alternative)

2018-12-13 Thread Bas Nieuwenhuizen
On Thu, Dec 13, 2018 at 4:52 PM Alex Deucher wrote: > > On Wed, Dec 12, 2018 at 3:42 AM Samuel Pitoiset > wrote: > > > > Personally, I will continue to use the list, at least for a simplicity > > point of view. I'm not sure if using a new tool will improve quality and > > code review process. >

Re: [Mesa-dev] [PATCH v2] docs: Document GitLab merge request process (email alternative)

2018-12-13 Thread Axel Davy
On 13/12/2018 17:57, Mathias Fröhlich wrote: Hi, Initially it seemed to me that I am about the only one sticking with mailing lists. And I personally feel like a too small contributor to really try to influence your decisions too much. But these recent hand full of mails all tell me that I am

Re: [Mesa-dev] [PATCH v2] docs: Document GitLab merge request process (email alternative)

2018-12-13 Thread Ilia Mirkin
On Thu, Dec 13, 2018 at 11:41 AM Jason Ekstrand wrote: > > On Thu, Dec 13, 2018 at 9:56 AM Ilia Mirkin wrote: >> >> On Thu, Dec 13, 2018 at 10:52 AM Alex Deucher wrote: >> > >> > On Wed, Dec 12, 2018 at 3:42 AM Samuel Pitoiset >> > wrote: >> > > >> > > Personally, I will continue to use the

Re: [Mesa-dev] [PATCH v2] docs: Document GitLab merge request process (email alternative)

2018-12-13 Thread Alex Deucher
On Thu, Dec 13, 2018 at 11:41 AM Jason Ekstrand wrote: > > On Thu, Dec 13, 2018 at 9:56 AM Ilia Mirkin wrote: >> >> On Thu, Dec 13, 2018 at 10:52 AM Alex Deucher wrote: >> > >> > On Wed, Dec 12, 2018 at 3:42 AM Samuel Pitoiset >> > wrote: >> > > >> > > Personally, I will continue to use the

Re: [Mesa-dev] [PATCH v2] docs: Document GitLab merge request process (email alternative)

2018-12-13 Thread Mathias Fröhlich
Hi, On Thursday, 13 December 2018 17:40:49 CET Jason Ekstrand wrote: > On Thu, Dec 13, 2018 at 9:56 AM Ilia Mirkin wrote: > > > On Thu, Dec 13, 2018 at 10:52 AM Alex Deucher > > wrote: > > > > > > On Wed, Dec 12, 2018 at 3:42 AM Samuel Pitoiset > > > wrote: > > > > > > > > Personally, I will

Re: [Mesa-dev] [PATCH v2] docs: Document GitLab merge request process (email alternative)

2018-12-13 Thread Jason Ekstrand
On Thu, Dec 13, 2018 at 9:56 AM Ilia Mirkin wrote: > On Thu, Dec 13, 2018 at 10:52 AM Alex Deucher > wrote: > > > > On Wed, Dec 12, 2018 at 3:42 AM Samuel Pitoiset > > wrote: > > > > > > Personally, I will continue to use the list, at least for a simplicity > > > point of view. I'm not sure if

Re: [Mesa-dev] [PATCH v2] docs: Document GitLab merge request process (email alternative)

2018-12-13 Thread Michel Dänzer
On 2018-12-13 4:52 p.m., Alex Deucher wrote: > On Wed, Dec 12, 2018 at 3:42 AM Samuel Pitoiset > wrote: >> >> Personally, I will continue to use the list, at least for a simplicity >> point of view. I'm not sure if using a new tool will improve quality and >> code review process. >> >> Though, if

Re: [Mesa-dev] [PATCH v2] docs: Document GitLab merge request process (email alternative)

2018-12-13 Thread Ilia Mirkin
On Thu, Dec 13, 2018 at 10:52 AM Alex Deucher wrote: > > On Wed, Dec 12, 2018 at 3:42 AM Samuel Pitoiset > wrote: > > > > Personally, I will continue to use the list, at least for a simplicity > > point of view. I'm not sure if using a new tool will improve quality and > > code review process. >

Re: [Mesa-dev] [PATCH v2] docs: Document GitLab merge request process (email alternative)

2018-12-13 Thread Alex Deucher
On Wed, Dec 12, 2018 at 3:42 AM Samuel Pitoiset wrote: > > Personally, I will continue to use the list, at least for a simplicity > point of view. I'm not sure if using a new tool will improve quality and > code review process. > > Though, if the majority reports that is really nice to use, I

Re: [Mesa-dev] [PATCH v2] docs: Document GitLab merge request process (email alternative)

2018-12-12 Thread Erik Faye-Lund
On Tue, 2018-12-11 at 18:06 -0600, Jason Ekstrand wrote: > Ping? > > I see about 5 acks/reviews, 3 of which are from Intel which doesn't > exactly seem like overwhelming consensus. However, we also haven't > had any debate in a while. Oh, absolutely, I'm very much a supporter of tring this out!

Re: [Mesa-dev] [PATCH v2] docs: Document GitLab merge request process (email alternative)

2018-12-12 Thread Samuel Pitoiset
Personally, I will continue to use the list, at least for a simplicity point of view. I'm not sure if using a new tool will improve quality and code review process. Though, if the majority reports that is really nice to use, I will probably change my mind. Not a strong reject. On 12/6/18

Re: [Mesa-dev] [PATCH v2] docs: Document GitLab merge request process (email alternative)

2018-12-11 Thread Jason Ekstrand
On Tue, Dec 11, 2018 at 8:15 PM Ian Romanick wrote: > It's fairly common for Mesa developers to have several patch series on > the mailing list at a time. I believe most people will author these as > a continuous stream with either implicit dependencies (i.e., commit > messages in the second

Re: [Mesa-dev] [PATCH v2] docs: Document GitLab merge request process (email alternative)

2018-12-11 Thread Ian Romanick
It's fairly common for Mesa developers to have several patch series on the mailing list at a time. I believe most people will author these as a continuous stream with either implicit dependencies (i.e., commit messages in the second series with shader-db results that are impacted by the first

Re: [Mesa-dev] [PATCH v2] docs: Document GitLab merge request process (email alternative)

2018-12-11 Thread Rob Clark
On Tue, Dec 11, 2018 at 7:06 PM Jason Ekstrand wrote: > > Ping? > > I see about 5 acks/reviews, 3 of which are from Intel which doesn't exactly > seem like overwhelming consensus. However, we also haven't had any debate in > a while. > > I know some people are somewhat skeptical as to how well

Re: [Mesa-dev] [PATCH v2] docs: Document GitLab merge request process (email alternative)

2018-12-11 Thread Bas Nieuwenhuizen
On Wed, Dec 12, 2018 at 1:06 AM Jason Ekstrand wrote: > > Ping? > > I see about 5 acks/reviews, 3 of which are from Intel which doesn't exactly > seem like overwhelming consensus. However, we also haven't had any debate in > a while. FWIW, I'm fine with it too. Acked-by: Bas Nieuwenhuizen

Re: [Mesa-dev] [PATCH v2] docs: Document GitLab merge request process (email alternative)

2018-12-11 Thread Jason Ekstrand
Ping? I see about 5 acks/reviews, 3 of which are from Intel which doesn't exactly seem like overwhelming consensus. However, we also haven't had any debate in a while. I know some people are somewhat skeptical as to how well it will work but they won't be able to see until we actually start

Re: [Mesa-dev] [PATCH v2] docs: Document GitLab merge request process (email alternative)

2018-12-07 Thread Daniel Stone
Hi, On Sat, 8 Dec 2018 at 05:15, Eric Engestrom wrote: > On Friday, 2018-12-07 10:19:23 +0100, Erik Faye-Lund wrote: > > Automated emails (and perhaps IRC bot) would be really nice. > > Agreed. Email would be great to help with the transition. > There's work currently being done on GitLab to

Re: [Mesa-dev] [PATCH v2] docs: Document GitLab merge request process (email alternative)

2018-12-07 Thread Eric Engestrom
On Friday, 2018-12-07 10:19:23 +0100, Erik Faye-Lund wrote: > On Wed, 2018-12-05 at 21:46 -0600, Jason Ekstrand wrote: > > On Wed, Dec 5, 2018 at 7:05 PM Jordan Justen < > > jordan.l.jus...@intel.com> wrote: > > > On 2018-12-05 15:44:18, Jason Ekstrand wrote: > > > > On Wed, Dec 5, 2018 at 5:32 PM

Re: [Mesa-dev] [PATCH v2] docs: Document GitLab merge request process (email alternative)

2018-12-07 Thread Eric Engestrom
On Wednesday, 2018-12-05 15:32:05 -0800, Jordan Justen wrote: > This documents a process for using GitLab Merge Requests as an second > way to submit code changes for Mesa. Only one of the two methods is > allowed for each patch series. > > We will *not* require all patches to be emailed. Some

Re: [Mesa-dev] [PATCH v2] docs: Document GitLab merge request process (email alternative)

2018-12-07 Thread Erik Faye-Lund
Reviewed-by: Erik Faye-Lund On Wed, 2018-12-05 at 15:32 -0800, Jordan Justen wrote: > This documents a process for using GitLab Merge Requests as an second > way to submit code changes for Mesa. Only one of the two methods is > allowed for each patch series. > > We will *not* require all

Re: [Mesa-dev] [PATCH v2] docs: Document GitLab merge request process (email alternative)

2018-12-07 Thread Erik Faye-Lund
On Wed, 2018-12-05 at 21:46 -0600, Jason Ekstrand wrote: > On Wed, Dec 5, 2018 at 7:05 PM Jordan Justen < > jordan.l.jus...@intel.com> wrote: > > On 2018-12-05 15:44:18, Jason Ekstrand wrote: > > > On Wed, Dec 5, 2018 at 5:32 PM Jordan Justen < > > jordan.l.jus...@intel.com> > > > wrote: > > > >

Re: [Mesa-dev] [PATCH v2] docs: Document GitLab merge request process (email alternative)

2018-12-06 Thread Jordan Justen
On 2018-12-06 13:57:09, Nicolai Hähnle wrote: > On 06.12.18 00:32, Jordan Justen wrote: > > + To participate in code review, you should monitor the > > + https://lists.freedesktop.org/mailman/listinfo/mesa-dev;> > > + mesa-dev email list and the GitLab > > + Mesa >

Re: [Mesa-dev] [PATCH v2] docs: Document GitLab merge request process (email alternative)

2018-12-06 Thread Jason Ekstrand
On Thu, Dec 6, 2018 at 3:57 PM Nicolai Hähnle wrote: > On 06.12.18 00:32, Jordan Justen wrote: > > This documents a process for using GitLab Merge Requests as an second > > way to submit code changes for Mesa. Only one of the two methods is > > allowed for each patch series. > > > > We will

Re: [Mesa-dev] [PATCH v2] docs: Document GitLab merge request process (email alternative)

2018-12-06 Thread Nicolai Hähnle
On 06.12.18 00:32, Jordan Justen wrote: This documents a process for using GitLab Merge Requests as an second way to submit code changes for Mesa. Only one of the two methods is allowed for each patch series. We will *not* require all patches to be emailed. Some code changes may be reviewed and

Re: [Mesa-dev] [PATCH v2] docs: Document GitLab merge request process (email alternative)

2018-12-06 Thread Dylan Baker
Quoting Jordan Justen (2018-12-05 15:32:05) > This documents a process for using GitLab Merge Requests as an second > way to submit code changes for Mesa. Only one of the two methods is > allowed for each patch series. > > We will *not* require all patches to be emailed. Some code changes may >

Re: [Mesa-dev] [PATCH v2] docs: Document GitLab merge request process (email alternative)

2018-12-06 Thread Eric Anholt
Jordan Justen writes: > This documents a process for using GitLab Merge Requests as an second > way to submit code changes for Mesa. Only one of the two methods is > allowed for each patch series. > > We will *not* require all patches to be emailed. Some code changes may > be reviewed and merged

Re: [Mesa-dev] [PATCH v2] docs: Document GitLab merge request process (email alternative)

2018-12-05 Thread Jason Ekstrand
On Wed, Dec 5, 2018 at 7:05 PM Jordan Justen wrote: > On 2018-12-05 15:44:18, Jason Ekstrand wrote: > > On Wed, Dec 5, 2018 at 5:32 PM Jordan Justen > > wrote: > > > -Mailing Patches > > > +Submitting Patches > > > > > > > > > -Patches should be sent to the mesa-dev mailing list for review: >

Re: [Mesa-dev] [PATCH v2] docs: Document GitLab merge request process (email alternative)

2018-12-05 Thread Jordan Justen
On 2018-12-05 15:44:18, Jason Ekstrand wrote: > On Wed, Dec 5, 2018 at 5:32 PM Jordan Justen > wrote: > > -Mailing Patches > > +Submitting Patches > > > > > > -Patches should be sent to the mesa-dev mailing list for review: > > +Patches may be submitted to the Mesa project by > > +email or with

Re: [Mesa-dev] [PATCH v2] docs: Document GitLab merge request process (email alternative)

2018-12-05 Thread Jason Ekstrand
On Wed, Dec 5, 2018 at 5:32 PM Jordan Justen wrote: > This documents a process for using GitLab Merge Requests as an second > way to submit code changes for Mesa. Only one of the two methods is > allowed for each patch series. > > We will *not* require all patches to be emailed. Some code

[Mesa-dev] [PATCH v2] docs: Document GitLab merge request process (email alternative)

2018-12-05 Thread Jordan Justen
This documents a process for using GitLab Merge Requests as an second way to submit code changes for Mesa. Only one of the two methods is allowed for each patch series. We will *not* require all patches to be emailed. Some code changes may be reviewed and merged without any discussion on the