Re: [Mesa-dev] [PATCH v2] egl/android: rework device probing

2018-09-04 Thread Tomasz Figa
On Mon, Sep 3, 2018 at 3:25 PM Tomasz Figa wrote: > > On Mon, Sep 3, 2018 at 2:45 PM Tomasz Figa wrote: > > > > Hi Emil, > > > > On Sat, Sep 1, 2018 at 2:03 AM Emil Velikov > > wrote: > > > > > > From: Emil Velikov > > > > > > > Thanks for the patch! Please see my comments below. > > > >

Re: [Mesa-dev] [PATCH v2] egl/android: rework device probing

2018-09-03 Thread Tapani Pälli
I've tested that Android Celadon continues to work with these changes .. Tested-by: Tapani Pälli On 08/31/2018 07:59 PM, Emil Velikov wrote: From: Emil Velikov Unlike the other platforms, here we aim do guess if the device that we somewhat arbitrarily picked, is supported or not. In

Re: [Mesa-dev] [PATCH v2] egl/android: rework device probing

2018-09-03 Thread Eric Engestrom
On Monday, 2018-09-03 08:40:47 +0100, Eric Engestrom wrote: > On Friday, 2018-08-31 17:59:10 +0100, Emil Velikov wrote: > > From: Emil Velikov > > > > Unlike the other platforms, here we aim do guess if the device that we > > somewhat arbitrarily picked, is supported or not. > > > > In

Re: [Mesa-dev] [PATCH v2] egl/android: rework device probing

2018-09-03 Thread Eric Engestrom
On Friday, 2018-08-31 17:59:10 +0100, Emil Velikov wrote: > From: Emil Velikov > > Unlike the other platforms, here we aim do guess if the device that we > somewhat arbitrarily picked, is supported or not. > > In particular: when a vendor is _not_ requested we loop through all > devices,

Re: [Mesa-dev] [PATCH v2] egl/android: rework device probing

2018-09-03 Thread Tomasz Figa
On Mon, Sep 3, 2018 at 2:45 PM Tomasz Figa wrote: > > Hi Emil, > > On Sat, Sep 1, 2018 at 2:03 AM Emil Velikov wrote: > > > > From: Emil Velikov > > > > Thanks for the patch! Please see my comments below. > > [snip] > > @@ -1214,10 +1215,13 @@ droid_open_device_drm_gralloc(struct > >

Re: [Mesa-dev] [PATCH v2] egl/android: rework device probing

2018-09-02 Thread Tomasz Figa
Hi Emil, On Sat, Sep 1, 2018 at 2:03 AM Emil Velikov wrote: > > From: Emil Velikov > Thanks for the patch! Please see my comments below. [snip] > @@ -1214,10 +1215,13 @@ droid_open_device_drm_gralloc(struct dri2_egl_display > *dri2_dpy) >); >

[Mesa-dev] [PATCH v2] egl/android: rework device probing

2018-08-31 Thread Emil Velikov
From: Emil Velikov Unlike the other platforms, here we aim do guess if the device that we somewhat arbitrarily picked, is supported or not. In particular: when a vendor is _not_ requested we loop through all devices, picking the first one which can create a DRI screen. When a vendor is